569442 - Need to add VS2010 project files & ensure everything works properly

Status: RESOLVED FIXED

(Tamarin Graveyard :: Virtual Machine, defect, P1)

Description

[Steven Johnson]

VS2010 is out, we want to support it.

Comment 1

[Steven Johnson]

Note that it probably makes sense for someone on the QE side to bring buildbot up to date with this... so far it appears that the changes needed for the xplat build setup are trivial (just changing the env vars to point to the new compiler).

Comment 2

[Steven Johnson]

Attachment: Add VS2010 IDE project

Created from scratch rather than by importing the VS2008 ones; implemented as a single project rather than multiple projects. Note that I didn't bother attempting to include WinMo targets, only Win32 and Win64. Also note that the output uses the names proposed in Bug 478714, eg, "Release64/avm.exe", in anticipation of that change being made. Resulting binaries pass acceptance tests equivalently to VS2008 builds.

Note that the VS2010 builds are larger (924k vs 849k for 32-bit Release); I haven't yet attempted to see if there's a specific reason for the size increase or if it's just an overall different in compiled code.

The only source change I made was to shell code to use explicit Unicode entry points; this is perhaps gratuitous, but I arbitrarily decided to make the project "Unicode" rather than "Multibyte" since we no longer support non-unicode systems. LMK if this seems a poor idea...

No changes are needed to the xplat build setup per se, but changes to the env vars are necessary (ie, pointing at VS2010 vs. VS2008); however, that's probably better carried out by someone familiar with the buildbot system.

Comment 3

[Brent Baker]

Comment on attachment 448814 [details] [diff] [review]
Add VS2010 IDE project

tested compiled shells on win32 and win64 using solution file to compile.

Note that there have been a couple of new core/exec* files added that need to be added to this project file.

What is the timeline for EOL of the 2008 solution/project files?

Comment 4

[Steven Johnson]

(In reply to comment #3)
> What is the timeline for EOL of the 2008 solution/project files?

No one on tamarin-devel has commented on this issue, so we may be able to EOL them as soon as we are comfortable with VS2010. The one major piece missing is WinMo support; if we are going to continue building those as reference targets, we need to get those added to this project, but I no longer have any WinMo hardware set up to test against.

Comment 5

[Brent Baker]

(In reply to comment #4)
> The one major piece missing is
> WinMo support; if we are going to continue building those as reference targets,
> we need to get those added to this project, but I no longer have any WinMo
> hardware set up to test against.

Another issue here is that the move to Windows Phone 7 SDK requires Windows Vista or 7, it will not install on older versions of windows.
http://www.microsoft.com/downloads/details.aspx?displaylang=en&FamilyID=cabcd5ed-7dfc-4731-9d7e-3220603cad14

Comment 6

[Steven Johnson]

Pushed existing patch as http://hg.mozilla.org/tamarin-redux/rev/a0aa0ca690b3

re: requiring WinVista/7, is this an issue for the build systems? I think most devs are running modern systems now.

Comment 7

[Lars T Hansen]

Note also this patch, which fixes a regression introduced in the previous patch:

changeset:   4979:8db2922fd29e
tag:         tip
user:        Lars T Hansen <[e-mail]>
date:        Fri Aug 06 10:27:17 2010 +0200
summary:     Related to 569442  - Need to add VS2010 project files & ensure everything works properly: fix a wide-char regression in crash handler (patch=skadiogl, r=lhansen, push=lhansen)

Comment 8

[Andrew]

Attachment: Patch to fix visual studio 2010s project file

This is a trivial patch to fix visual studio 2010's project files

Comment 9

[Steven Johnson]

pushed: http://hg.mozilla.org/tamarin-redux/rev/b06807fe9e3a

Comment 10

[Jimmy Bahuleyan]

Attachment: Update VS2010 project files

Patch over tr:6609. vs2008 is still the official toolchain for tamarin, but get vs2010 back up for anyone who needs it.