569463 - [@ SVGMotionSMILAnimationFunction::RebuildPathAndVerticesFromMpathElem]

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[timeless]

248 SVGMotionSMILAnimationFunction::
249   RebuildPathAndVerticesFromMpathElem(nsSVGMpathElement* aMpathElem)

257       const nsAString& pathSpec =
258         pathElem->GetParsedAttr(nsGkAtoms::d)->GetStringValue();

according to coverity, there is only one other caller in the tree which doesn't null check the result form GetParsedAttr.

Comment 1

[Daniel Holbert [:dholbert]]

Note that we do check "HasAttr" before calling GetParsedAttr -- so I don't think it's possible for this particular call to return null.  Maybe there's a cleaner way to do things here, though.

You added the keyword "crash" -- do you have a testcase that crashes on this line?

Comment 2

[timeless]

Crashing is what would happen, I use it so that when someone does hit a crash and searches for it, they will find this bug recognize it's their crash and cc/comment/offer incident id's.

Comment 3

[Robert Longson [:longsonr]]

Attachment: patch

Comment 4

[Robert Longson [:longsonr]]

pushed http://hg.mozilla.org/mozilla-central/rev/18c728e4b4c6