569470 - useless casts in VideoData::Create

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[timeless]

156 class VideoData {
165   struct YCbCrBuffer {
166     struct Plane {
167       PRUint8* mData;
168       PRUint32 mWidth;
169       PRUint32 mHeight;
170       PRUint32 mStride;
171     };
173     Plane mPlanes[3];

88 VideoData* VideoData::Create(nsVideoInfo& aInfo,

127   if (!AddOverflow32(aInfo.mPicture.x, aInfo.mPicture.width, picXLimit) ||
128       picXLimit > PRUint32(aBuffer.mPlanes[0].mStride) ||
129       !AddOverflow32(aInfo.mPicture.y, aInfo.mPicture.height, picYLimit) ||
130       picYLimit > PRUint32(aBuffer.mPlanes[0].mHeight))

Both mHeight and mStride are already PRUint32 ....

Comment 1

[timeless]

Attachment: patch

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 448699 [details] [diff] [review]
patch

Thanks!

Comment 3

[timeless]

http://hg.mozilla.org/mozilla-central/rev/df335dcd27c7