Closed
Bug 569471
Opened 14 years ago
Closed 14 years ago
js_GetWrappedObject(cx, obj) => obj->wrappedObject(cx)
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: Waldo, Assigned: Waldo)
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file)
|
6.79 KB,
patch
|
jorendorff
:
review+
|
Details | Diff | Splinter Review |
It's unfortunate that trailing cx is also leading cx, but use of the convention that there's no get in an infallible method name hopefully will help.
Attachment #448621 -
Flags: review?(jorendorff)
|
||
Updated•14 years ago
|
Attachment #448621 -
Flags: review?(jorendorff) → review+
|
|
||
Comment 1•14 years ago
|
||
Comment on attachment 448621 [details] [diff] [review] Patch > /* >- * This call to js_GetWrappedObject is safe because of the security checks >+ * This call to JSObject::wrappedObject is safe because of the security checks > * we do below. However, the control flow below is confusing, so we double > * check. There are two cases: We still try to keep comments to 79 columns, right? This one goes to 82 with the change. r=me with that nit picked.
|
Assignee | |
Comment 2•14 years ago
|
||
http://hg.mozilla.org/tracemonkey/rev/97874793a87a with a timely picking of said nit, plus a little const- and cast-sprinkling needed to make things compile (discovered in a post-patch-upload browser build).
Whiteboard: fixed-in-tracemonkey
Target Milestone: --- → mozilla1.9.3a5
|
||
Comment 3•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/97874793a87a
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•