Closed
Bug 569475
Opened 14 years ago
Closed 14 years ago
qcms linking failure on mingw-w64
Categories
(Core :: Graphics: Color Management, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.3a5
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
592 bytes,
patch
|
jrmuizel
:
review+
|
Details | Diff | Splinter Review |
When compiling with mingw for win64, I get linking failure in gfx/qcms/transform.c, because SSE1 is not available. It's correctly handled in C:
#if !(defined(_MSC_VER) && defined(_M_AMD64))
/* Microsoft Compiler for x64 doesn't support MMX.
* SSE code uses MMX so that we disable on x64 */
but in makefile it's always disabled on win64, without compiler check. It should be disabled only on win64+msvc. The attached patch fixes the makefile problem.
|
Assignee | |
Updated•14 years ago
|
Attachment #448625 -
Attachment is patch: true
Attachment #448625 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → jacek
|
||
Updated•14 years ago
|
Attachment #448625 -
Flags: review?(jmuizelaar) → review+
|
||
Comment 2•14 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/0960840503a2
Status: NEW → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in
before you can comment on or make changes to this bug.
Description
•