update Page Worker API for forwards-compatibility with electrolysis

RESOLVED FIXED in 0.8

Status

defect
P1
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: myk, Assigned: myk)

Tracking

unspecified
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

9 years ago
The Page Worker API should be updated to be forwards-compatible with electrolysis.
Assigning to Brian, as the first step is his analysis of what we need to do here. Brian, assign back over when you post your comments.
Assignee: felipc → warner-bugzilla
Priority: -- → P2
Version: unspecified → Trunk
Assignee

Comment 2

9 years ago
My Panel implementation (bug 494238) uses Page Worker, and my WIP patches will incorporate whatever API changes are necessary, so marking this bug dependent on that one.
Depends on: jetpack-panel-apps

Updated

9 years ago
Depends on: 546740
Assignee

Comment 3

9 years ago
Taking in order to implement the solution we've been hashing out over in bug 494238.
Assignee: warner-bugzilla → myk
Status: NEW → ASSIGNED
Depends on: 585387
Assignee

Comment 4

9 years ago
Posted patch patch v1: implements change (obsolete) — Splinter Review
This is the relevant portion of the all-in-one patch in bug 494238, which I'm breaking into smaller pieces to make it easier to review.
Attachment #463871 - Flags: review?(dietrich)
Assignee

Updated

9 years ago
Priority: P2 → P1
Target Milestone: 0.5 → 0.8
does this still need review as-is? or does it need updating to contemporary e10s plans?
Assignee

Comment 6

9 years ago
(In reply to comment #5)
> does this still need review as-is? or does it need updating to contemporary
> e10s plans?

We could go either way.  "Contemporary e10s plans" is particularly 588737, whose changes will have to be made to Panel as well, which is already in the tree, so I think it's fine if Page Worker's current E10S-compatible implementation is in the tree as well (and then gets updated when Panel does).

Here's an updated patch that resolves conflicts in the documentation on the tip.
Attachment #463871 - Attachment is obsolete: true
Attachment #472317 - Flags: review?(dietrich)
Attachment #463871 - Flags: review?(dietrich)
Comment on attachment 472317 [details] [diff] [review]
patch v2: resolves conflicts with docs fixes in .md file

looks good, r=me. plan sounds fine.
Attachment #472317 - Flags: review?(dietrich) → review+
Assignee

Comment 8

9 years ago
Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/1e53a63b1d26.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Assignee

Comment 9

9 years ago
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.