569481 - update Page Worker API for forwards-compatibility with electrolysis

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Myk Melez [:myk] [@mykmelez]]

The Page Worker API should be updated to be forwards-compatible with electrolysis.

Comment 1

[Dietrich Ayala (:dietrich)]

Assigning to Brian, as the first step is his analysis of what we need to do here. Brian, assign back over when you post your comments.

Comment 2

[Myk Melez [:myk] [@mykmelez]]

My Panel implementation (bug 494238) uses Page Worker, and my WIP patches will incorporate whatever API changes are necessary, so marking this bug dependent on that one.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Taking in order to implement the solution we've been hashing out over in bug 494238.

Comment 4

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v1: implements change

This is the relevant portion of the all-in-one patch in bug 494238, which I'm breaking into smaller pieces to make it easier to review.

Comment 5

[Dietrich Ayala (:dietrich)]

does this still need review as-is? or does it need updating to contemporary e10s plans?

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Attachment: patch v2: resolves conflicts with docs fixes in .md file

(In reply to comment #5)
> does this still need review as-is? or does it need updating to contemporary
> e10s plans?

We could go either way.  "Contemporary e10s plans" is particularly 588737, whose changes will have to be made to Panel as well, which is already in the tree, so I think it's fine if Page Worker's current E10S-compatible implementation is in the tree as well (and then gets updated when Panel does).

Here's an updated patch that resolves conflicts in the documentation on the tip.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 472317 [details] [diff] [review]
patch v2: resolves conflicts with docs fixes in .md file

looks good, r=me. plan sounds fine.

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/1e53a63b1d26.

Comment 9

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".