Closed Bug 569528 Opened 15 years ago Closed 15 years ago

[HTML5] <h5> inside <button> inside <p> implicitly closes the <p>

Categories

(Core :: DOM: HTML Parser, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla2.0b7
Tracking Status
blocking2.0 --- final+

People

(Reporter: justin.lebar+bug, Assigned: hsivonen)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached file Testcase (obsolete) —
Originally filed as https://bugs.launchpad.net/bugs/588595 The following code: <p> <button> <h5>Bar</h5> </button> </p> results in the following DOM tree: <p> <button> </button></p><h5>Bar</h5> <p></p> which, of course, renders incorrectly. Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100601 Minefield/3.7a5pre
I'm affected on Ubuntu as well, so this seems to be platform independent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a5pre) Gecko/20100601 Ubuntu/10.04 (lucid) Minefield/3.7a5pre
OS: Windows XP → All
Hardware: x86 → All
Attached file Actual test case
The test case isn't really a test case for this bug. Attaching a test case. The behavior (and the spec) here changed at bug 558302 in an effort to match WebKit and IE8 more closely. It appears that spec and parser change didn't quite capture all important aspects of WebKit and IE8 behavior.
Assignee: nobody → hsivonen
Attachment #448693 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Summary: [HTML5] <h5> inside <button> inside <p> handled incorrectly → [HTML5] <h5> inside <button> inside <p> implicitly closes the <p>
Blocks: 558302
blocking2.0: --- → ?
blocking2.0: ? → final+
Henri, is this invalid HTML?
(In reply to comment #6) > Henri, is this invalid HTML? Not per the current draft, I believe. It's clear that the parser needs changing. I'll get to it.
This patch doesn't have a test case, because bug 559023 will add more than enough <button> test cases.
Attachment #473095 - Flags: review?(jonas)
Blocks: 578568
Depends on: 559023
Comment on attachment 473095 [details] [diff] [review] Fix implementing spec revision 5158 rs=me
Attachment #473095 - Flags: review?(jonas) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Marking as in-testsuite?, since the test cases will land as part of bug 559023.
Flags: in-testsuite?
Test landed as part of bug 559023.
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: