[HTML5] <h5> inside <button> inside <p> implicitly closes the <p>

RESOLVED FIXED in mozilla2.0b7

Status

()

defect
P2
normal
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: justin.lebar+bug, Assigned: hsivonen)

Tracking

Trunk
mozilla2.0b7
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(blocking2.0 final+)

Details

Attachments

(2 attachments, 1 obsolete attachment)

Posted file Testcase (obsolete) —
Originally filed as https://bugs.launchpad.net/bugs/588595

The following code:

      <p> <button> <h5>Bar</h5> </button> </p>

results in the following DOM tree:

     <p> <button> </button></p><h5>Bar</h5>  <p></p>

which, of course, renders incorrectly.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a5pre) Gecko/20100601 Minefield/3.7a5pre
I'm affected on Ubuntu as well, so this seems to be platform independent:
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a5pre) Gecko/20100601 Ubuntu/10.04 (lucid) Minefield/3.7a5pre
OS: Windows XP → All
Hardware: x86 → All
Posted file Actual test case
The test case isn't really a test case for this bug. Attaching a test case.

The behavior (and the spec) here changed at bug 558302 in an effort to match WebKit and IE8 more closely. It appears that spec and parser change didn't quite capture all important aspects of WebKit and IE8 behavior.
Assignee: nobody → hsivonen
Attachment #448693 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Summary: [HTML5] <h5> inside <button> inside <p> handled incorrectly → [HTML5] <h5> inside <button> inside <p> implicitly closes the <p>
Blocks: 558302
blocking2.0: ? → final+
Duplicate of this bug: 575244
Duplicate of this bug: 593114
Henri, is this invalid HTML?
(In reply to comment #6)
> Henri, is this invalid HTML?

Not per the current draft, I believe.

It's clear that the parser needs changing. I'll get to it.
This patch doesn't have a test case, because bug 559023 will add more than enough <button> test cases.
Attachment #473095 - Flags: review?(jonas)
Blocks: 578568
Depends on: 559023
Comment on attachment 473095 [details] [diff] [review]
Fix implementing spec revision 5158

rs=me
Attachment #473095 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/41aaa362225b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Marking as in-testsuite?, since the test cases will land as part of bug 559023.
Flags: in-testsuite?
Test landed as part of bug 559023.
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla2.0b7
You need to log in before you can comment on or make changes to this bug.