Closed Bug 569529 Opened 10 years ago Closed 10 years ago
Make Set* methods in ns
ROCSSPrimitive Value non-inline
Noticed a FIXME in the code that said to make these non-inline so I did.
Attachment #448697 - Flags: review?(dbaron)
Attachment #448697 - Flags: review?(dbaron) → review+
Comment on attachment 448697 [details] [diff] [review] Move methods from header file to cpp file In the SetNumber implementations, could you leave the construction-style cast rather than switching to static_cast<float>? In SetString, could you duplicate the FIXME at the implementation too? Also, while you're here, could you change the signature of Reset from Reset(void) to Reset(). There's a difference in C, but in C++ the (void) is silly. r=dbaron with that
Attachment #448954 - Flags: review?(dbaron) → review+
Comment on attachment 448954 [details] [diff] [review] Address review comments and remove two QIs r=dbaron, except this doesn't have the bit to remove two QIs that you mentioned
Doh! Forgot to create the patch file after I changed the file.
Attachment #448959 - Flags: review?(dbaron) → review+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.