Make Set* methods in nsROCSSPrimitiveValue non-inline

RESOLVED FIXED in mozilla1.9.3a5

Status

()

Core
CSS Parsing and Computation
--
minor
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: Craig Topper, Assigned: Craig Topper)

Tracking

Trunk
mozilla1.9.3a5
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 448697 [details] [diff] [review]
Move methods from header file to cpp file

Noticed a FIXME in the code that said to make these non-inline so I did.
Attachment #448697 - Flags: review?(dbaron)
Attachment #448697 - Flags: review?(dbaron) → review+
Comment on attachment 448697 [details] [diff] [review]
Move methods from header file to cpp file

In the SetNumber implementations, could you leave the construction-style
cast rather than switching to static_cast<float>?

In SetString, could you duplicate the FIXME at the implementation too?

Also, while you're here, could you change the signature of Reset
from Reset(void) to Reset().  There's a difference in C, but in C++
the (void) is silly.

r=dbaron with that
(Assignee)

Comment 2

8 years ago
Created attachment 448954 [details] [diff] [review]
Address review comments and remove two QIs
Attachment #448697 - Attachment is obsolete: true
Attachment #448954 - Flags: review?(dbaron)
Attachment #448954 - Flags: review?(dbaron) → review+
Comment on attachment 448954 [details] [diff] [review]
Address review comments and remove two QIs

r=dbaron, except this doesn't have the bit to remove two QIs that you mentioned
Keywords: checkin-needed
(Assignee)

Comment 4

8 years ago
Doh! Forgot to create the patch file after I changed the file.
(Assignee)

Comment 5

8 years ago
Created attachment 448959 [details] [diff] [review]
Add the QIs
Attachment #448954 - Attachment is obsolete: true
Attachment #448959 - Flags: review?(dbaron)
Attachment #448959 - Flags: review?(dbaron) → review+
http://hg.mozilla.org/mozilla-central/rev/319ff487e286
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
You need to log in before you can comment on or make changes to this bug.