Closed
Bug 569547
Opened 16 years ago
Closed 16 years ago
fastcall useless on win64
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla2.0b1
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
468 bytes,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
When I compile on mingw-w64 I get tons of warnings like:
warning: '__fastcall__' attribute ignored
It's right, fastcall is useless on win64 as its cdecl is like fastcall on i386. The attached patch fixes the problem.
|
Assignee | |
Updated•16 years ago
|
Attachment #448718 -
Attachment is patch: true
Attachment #448718 -
Flags: review?(benjamin)
|
||
Updated•16 years ago
|
Attachment #448718 -
Flags: review?(benjamin) → review+
|
|
||
Comment 1•16 years ago
|
||
Comment on attachment 448718 [details] [diff] [review]
fix v1.0
I'd slightly prefer XP_WIN && x86, but I don't know the right incantation for that, so I guess this is fine!
|
|
Assignee | |
Updated•16 years ago
|
Assignee: nobody → jacek
|
||
Comment 3•16 years ago
|
||
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
|
|
||
Updated•16 years ago
|
Target Milestone: mozilla1.9.3a5 → mozilla1.9.3a6
You need to log in
before you can comment on or make changes to this bug.
Description
•