569572 - Events from eGroupware CalDAV resource are not displayed when program is started

Status: RESOLVED FIXED

(Calendar :: Provider: CalDAV, defect)

Description

[karaluh]

User-Agent:       Mozilla/5.0 (X11; U; Linux; pl-PL) AppleWebKit/532.4 (KHTML, like Gecko) rekonq Safari/532.4
Build Identifier: Sunbird and lightning beta 1

As in summary. To display the events you have to create a new one. Cache is enabled.

Reproducible: Always

Comment 1

[karaluh]

Still there in beta 2 rc1

Comment 2

[Simon Vaillancourt]

Is it possible to have a test account and config info for this server?  Thanks.

Comment 3

[karaluh]

I've sent you an e-mail with the test acount details. Configuration:
server: http://83.13.159.107/egroupware/groupdav.php/calendar
show reminders and cache enabled.

Comment 4

[Simon Vaillancourt]

Attachment: Fix for eGroupware caldav support

This issue is caused by 2 things:
1) eGroupWare server does not have the resourcetype property set on all its DAV resources as required by RFC 4918, which means that a response element from a eGroupWare server looks like this (Note the unexpected Status 404):

 <D:response xmlns:ns0="urn:uuid:c2f41010-65b3-11d1-a29f-00aa00c14882/">
  <D:href>http://83.13.159.107/egroupware/groupdav.php/calendar/336.ics</D:href>
   <D:propstat>
    <D:prop>
     <D:getetag>336:2:a77a8ddbf537ba706b65e02ce901fb68</D:getetag>
     <D:getcontenttype>text/calendar; charset=utf-8; component=VEVENT</D:getcontenttype>
   </D:prop>
   <D:status>HTTP/1.1 200 OK</D:status>
  </D:propstat>
   <D:propstat>
    <D:prop>
     <D:resourcetype/>
   </D:prop>
   <D:status>HTTP/1.1 404 Not Found</D:status>
  </D:propstat>
 </D:response>

2) Bad parsing of the status element in the calDav request handler means that it thinks the response status is 404 (there is no response status in a propfind response, only propstat status.

Fix: Remove the unneeded status check, relying on the href, getcontenttype and etag being set to non-null values is sufficient to determine if we should do a multiget on each resources.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 456162 [details] [diff] [review]
Fix for eGroupware caldav support

Looks fine, r=philipp

Comment 6

[Stefan Sitter [:ssitter]]

Does this fix Bug 579553 too? Is it the same issue or a different issue?

Comment 7

[Martin Schröder [:mschroeder]]

Setting checkin-needed as this patch had been reviewed almost two weeks ago, and no checkin occurred.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/5e2cc46e7154>
-> FIXED

Comment 9

[Swen]

We are still having problems regarding this issue. Using Shredder 3.3a1pre and Lightning 1.1a1pre we get the "404 not found" server response mentioned in comment 4. Shall I re-open the bug?

Comment 10

[Martin Schröder [:mschroeder]]

(In reply to comment #9)
> We are still having problems regarding this issue. Using Shredder 3.3a1pre and
> Lightning 1.1a1pre we get the "404 not found" server response mentioned in
> comment 4. Shall I re-open the bug?

Swen, please open a new one and reference this bug.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to comm-1.9.2 <http://hg.mozilla.org/releases/comm-1.9.2/rev/b1c32b17b54f>

a=philipp