Closed Bug 569584 Opened 13 years ago Closed 13 years ago

Add ability to provide directory where private keys reside while building XPI

Categories

(Add-on SDK Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: zalun, Assigned: warner)

Details

Attachments

(1 file)

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/533.2 (KHTML, like Gecko) Chrome/5.0.342.9 Safari/533.2
Build Identifier: 

Again - for FlkightDeck.
We store the keys in database and while it's OK to export them to the file for XPI build, it would be great if we would be able to tell cfx where to look for them

Reproducible: Always
Brian: is this something that it would be relatively straightforward to add to cfx?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Yes.. I'll add this one.
Assignee: nobody → warner-bugzilla
Status: NEW → ASSIGNED
Brian: do you have an update on the status of this work?  It'd be great to have something in the next few days, as we're freezing FlightDeck development next Tuesday in preparation for the second preview release the following week, and we'd really like to have FlightDeck using the latest version of the SDK for it.
This adds a --keydir=PATH argument. The default is ~/.jetpack/keys , but a flightdeck process probably wants to create a new single-use tempdir and point it at that instead. 'cfx xpi' will expect to see a file in this directory named e.g. "jid0-"+JID .
Attachment #449354 - Flags: review?(avarma)
Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Piotr: does this do what you need?
Attachment #449354 - Flags: review?(zaloon)
FYI, I'm out of the office (and mostly offline) from tonight until next tuesday: if this passes review, please feel free to land it without me.
I haven't installed the patch - but that's what I want - yes
Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Looks good!
Attachment #449354 - Flags: review?(avarma) → review+
Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/51ec86d2ed22.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Working like a charm
The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".
Component: Jetpack SDK → General
Product: Mozilla Labs → Add-on SDK
QA Contact: jetpack-sdk → general
Resolution: FIXED → WONTFIX
Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Review of attachment 449354 [details] [diff] [review]:
-----------------------------------------------------------------

x
Attachment #449354 - Flags: review+
Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

clearing very very old r? flags
Attachment #449354 - Flags: review?(zaloon)
You need to log in before you can comment on or make changes to this bug.