569584 - Add ability to provide directory where private keys reside while building XPI

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Piotr Zalewa [:zalun]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/533.2 (KHTML, like Gecko) Chrome/5.0.342.9 Safari/533.2
Build Identifier: 

Again - for FlkightDeck.
We store the keys in database and while it's OK to export them to the file for XPI build, it would be great if we would be able to tell cfx where to look for them

Reproducible: Always

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Brian: is this something that it would be relatively straightforward to add to cfx?

Comment 2

[Brian Warner [:warner :bwarner]]

Yes.. I'll add this one.

Comment 3

[Myk Melez [:myk] [@mykmelez]]

Brian: do you have an update on the status of this work?  It'd be great to have something in the next few days, as we're freezing FlightDeck development next Tuesday in preparation for the second preview release the following week, and we'd really like to have FlightDeck using the latest version of the SDK for it.

Comment 4

[Brian Warner [:warner :bwarner]]

Attachment: adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

This adds a --keydir=PATH argument. The default is ~/.jetpack/keys , but a flightdeck process probably wants to create a new single-use tempdir and point it at that instead. 'cfx xpi' will expect to see a file in this directory named e.g. "jid0-"+JID .

Comment 5

[Brian Warner [:warner :bwarner]]

Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Piotr: does this do what you need?

Comment 6

[Brian Warner [:warner :bwarner]]

FYI, I'm out of the office (and mostly offline) from tonight until next tuesday: if this passes review, please feel free to land it without me.

Comment 7

[Piotr Zalewa [:zalun]]

I haven't installed the patch - but that's what I want - yes

Comment 8

[Atul Varma [:atul]]

Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Looks good!

Comment 9

[Myk Melez [:myk] [@mykmelez]]

Fixed by changeset https://hg.mozilla.org/labs/jetpack-sdk/rev/51ec86d2ed22.

Comment 10

[Piotr Zalewa [:zalun]]

Working like a charm

Comment 11

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".

Comment 12

[Piotr Zalewa [:zalun]]

Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

Review of attachment 449354 [details] [diff] [review]:
-----------------------------------------------------------------

x

Comment 13

[Brian Warner [:warner :bwarner]]

Comment on attachment 449354 [details] [diff] [review]
adds --keydir=PATH argument, used by 'cfx xpi' and 'cfx run'

clearing very very old r? flags