nsNativeAppSupportWin.cpp compilation failure on mingw-w64 due to pointer to int casts loosing precision.

RESOLVED FIXED

Status

Toolkit Graveyard
XULRunner
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
Created attachment 448758 [details] [diff] [review]
fix v1.0

I get following errors:

toolkit/xre/nsNativeAppSupportWin.cpp:392:85: error: cast from 'void*' to 'long int' loses precision
toolkit/xre/nsNativeAppSupportWin.cpp:405:82: error: cast from 'void*' to 'long int' loses precision
toolkit/xre/nsNativeAppSupportWin.cpp:649:54: error: cast from 'HWND__*' to 'long int' loses precision

The obvious fix are proper casts. While I was at this I've also fixed warnings:

toolkit/xre/nsNativeAppSupportWin.cpp:1164:20: warning: unused variable 'new_window'
toolkit/xre/nsNativeAppSupportWin.cpp:1264:80: warning: passing NULL to non-pointer argument 4 of 'DWORD DdeQueryStringW(DWORD, HSZ__*, WCHAR*, DWORD, int)'
(Assignee)

Updated

8 years ago
Attachment #448758 - Attachment is patch: true
Attachment #448758 - Flags: review?(timeless)

Comment 1

8 years ago
Comment on attachment 448758 [details] [diff] [review]
fix v1.0

please try to use hg to generate diffs (preferably against hg.mozilla.org/mozilla-central), git index lines don't help us.
Attachment #448758 - Flags: review?(timeless) → review+
(Assignee)

Comment 2

8 years ago
Thanks for review. I will try sending better diffs.
Keywords: checkin-needed

Updated

8 years ago
Assignee: nobody → jacek
(Assignee)

Updated

8 years ago
Blocks: 570342
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/mozilla-central/rev/5b6c27eb0011
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.