Created attachment 448758 [details] [diff] [review] fix v1.0 I get following errors: toolkit/xre/nsNativeAppSupportWin.cpp:392:85: error: cast from 'void*' to 'long int' loses precision toolkit/xre/nsNativeAppSupportWin.cpp:405:82: error: cast from 'void*' to 'long int' loses precision toolkit/xre/nsNativeAppSupportWin.cpp:649:54: error: cast from 'HWND__*' to 'long int' loses precision The obvious fix are proper casts. While I was at this I've also fixed warnings: toolkit/xre/nsNativeAppSupportWin.cpp:1164:20: warning: unused variable 'new_window' toolkit/xre/nsNativeAppSupportWin.cpp:1264:80: warning: passing NULL to non-pointer argument 4 of 'DWORD DdeQueryStringW(DWORD, HSZ__*, WCHAR*, DWORD, int)'
Comment on attachment 448758 [details] [diff] [review] fix v1.0 please try to use hg to generate diffs (preferably against hg.mozilla.org/mozilla-central), git index lines don't help us.
Attachment #448758 - Flags: review?(timeless) → review+
Thanks for review. I will try sending better diffs.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.