Closed
Bug 569590
Opened 15 years ago
Closed 15 years ago
nsNativeAppSupportWin.cpp compilation failure on mingw-w64 due to pointer to int casts loosing precision.
Categories
(Toolkit Graveyard :: XULRunner, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jacek, Assigned: jacek)
References
Details
Attachments
(1 file)
|
2.43 KB,
patch
|
timeless
:
review+
|
Details | Diff | Splinter Review |
I get following errors:
toolkit/xre/nsNativeAppSupportWin.cpp:392:85: error: cast from 'void*' to 'long int' loses precision
toolkit/xre/nsNativeAppSupportWin.cpp:405:82: error: cast from 'void*' to 'long int' loses precision
toolkit/xre/nsNativeAppSupportWin.cpp:649:54: error: cast from 'HWND__*' to 'long int' loses precision
The obvious fix are proper casts. While I was at this I've also fixed warnings:
toolkit/xre/nsNativeAppSupportWin.cpp:1164:20: warning: unused variable 'new_window'
toolkit/xre/nsNativeAppSupportWin.cpp:1264:80: warning: passing NULL to non-pointer argument 4 of 'DWORD DdeQueryStringW(DWORD, HSZ__*, WCHAR*, DWORD, int)'
|
Assignee | |
Updated•15 years ago
|
Attachment #448758 -
Attachment is patch: true
Attachment #448758 -
Flags: review?(timeless)
Comment on attachment 448758 [details] [diff] [review]
fix v1.0
please try to use hg to generate diffs (preferably against hg.mozilla.org/mozilla-central), git index lines don't help us.
Attachment #448758 -
Flags: review?(timeless) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Thanks for review. I will try sending better diffs.
Keywords: checkin-needed
|
||
Updated•15 years ago
|
Assignee: nobody → jacek
|
|
Assignee | |
Comment 3•15 years ago
|
||
|
||
Updated•9 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•