569666 - global.ctypes shouldn't be enumerable

Status: RESOLVED FIXED

(Core :: js-ctypes, defect)

Description

[Jeff Walden [:Waldo]]

Attachment: Patch

None of the other global names are enumerable, it's odd man out, and it also happens to break uneval(global) right now in full-browser builds inside the JS shell.

Also, NULL getter/setter means use the object's class's getter/setter, which may be something awful -- not the easy, nice, traceable JS_PropertyStub.

Comment 1

[Jason Orendorff [:jorendorff]]

Comment on attachment 448805 [details] [diff] [review]
Patch

Right. This is the easiest way to recover the tests that have been failing ever since js-ctypes landed. We shouldn't have let them go this long.

Comment 2

[[e-mail]]

I think there are other cases of NULL getter/setter where the class doesn't have anything interesting, in that file -- if you feel like it you could check those too :)

Comment 3

[Jeff Walden [:Waldo]]

http://hg.mozilla.org/tracemonkey/rev/611696dd3663

Only fixing the one instance because it happened to be driveby -- others should be fixed, but aiming for the narrowest fix possible here rather than get bogged down in "irrelevancies".

Comment 4

[Robert Sayre]

http://hg.mozilla.org/mozilla-central/rev/611696dd3663