569694 - Add-ons on User profile page need to be sorted by popularity

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P5)

Description

[krupa raj[:krupa]]

As per Fligtar,the add-ons on user profile page need to be sorted by popularity.

Comment 1

[Barry Chen]

Committed @ https://github.com/chenba/zamboni/commit/c99afe04cfd336b3de42d4146ec26b2c471540b9

The list is now sorted by weekly downloads.  If popularity meant something else, let me know.

Comment 2

[Wil Clouser [:clouserw]]

please close bugs when they're fixed, thanks

Comment 3

[krupa raj[:krupa]]

STR:

1. Load https://addons.allizom.org/z/en-US/firefox/user/9/
2. Notice the weekly downloads for "Download Sort" and "Download Statusbar"

observed behavior:
"Download Sort" with weekly downloads of 68 is listed above "Download Statusbar" which has 16,909 weekly downloads


Total download stats:

Download Sort = 583,604
Download Statusbar = 32,708,180

Whether we consider weekly downloads or total downloads, "Download Statusbar" should be listed above "Download Sort"

Reopening..

Comment 4

[krupa raj[:krupa]]

Attachment: screenshot

Comment 5

[Barry Chen]

(In reply to comment #2)
> please close bugs when they're fixed, thanks

@clouserw should I mark it as fixed even if it's not in jbalogh/master yet (in the few previous bugs I marked it fixed only when I pushed to jbalogh/master)?  If I committed to my branch, how should I request review?

Comment 6

[Wil Clouser [:clouserw]]

Oh, reopening then.  I saw the URL and thought it was on master.  Please put on master and then close.

Comment 7

[Barry Chen]

Now in jbalogh/master: https://github.com/jbalogh/zamboni/commit/4f2f4cbb551394f0055fef132c13f180d8e9fb8a

Comment 8

[krupa raj[:krupa]]

verified fixed @

https://addons.allizom.org/z/en-US/firefox/user/9/

profiles with pagination:

https://addons.allizom.org/z/en-US/firefox/user/37347/?page=1

Thunderbird:
https://addons.allizom.org/z/en-US/thunderbird/user/7349/

Mobile:
https://addons.allizom.org/z/en-US/mobile/user/5133025/

Checked in de and ja locales.