56979 - Tree doesn't repaint after multi-delete

Status: RESOLVED FIXED

(Core :: XUL, defect, P2)

Description

[selmer (gone)]

10/16 08 MN6

Open IMAP mailbox
use splitter to close message pane
use ctrl-click to select many messages
use shift-delete to delete them

result:  tree partially updates and then hangs with huge whitespace

After waiting a while, when I used the splitter to cause a reflow, the content
appears again and the delete operation is finished.

Comment 1

[selmer (gone)]

10/16 08 MN6 on NT

reproduced same problem in these circumstances:
6 messages in inbox; selected 4th msg & read in message pane; ctrl-click 5th
message; shift-delete.

result is first 3 messages, 2 blank lines, 6th message.  Nothing happens for a
minute, move splitter fractionally and 2 blank lines go away and last message
moves up next to first 3 messages as it should.

Nom RTM because I believe multi-delete is very common and this is a recent
regression.

Comment 2

[Peter Trudelle]

Possible dup of bug 44093? please check.

Comment 3

[scalkins]

This affects Aim buddy list when importing or deleting buddies also. 

Comment 4

[selmer (gone)]

I'm not sure how this could be a dup of a crasher.  There is no crash in this
bug.  Perhaps it will be fixed as a side-effect of 44093, or perhaps you meant a
different bug?

Comment 5

[John Morrison]

Actually, I suggested this was a dup, based on the knowledge that this 
type of behaviour in the tree widget occurs in (roughly speaking) the 
same area of code. But I didn't look closely at the proposed patch, and I 
see now that it is bailing out only on what would have been a crash. So,
the behaviour noted in this bug will still be observed. Sorry for the 
false lead (but, hey, if it's any consolation, you will now be less likely
to hit the crash :-])

Comment 6

[selmer (gone)]

Hey, not crashing is a Good Thing (TM)  ;^}

Adding Trudelle to the CC since no whiteboard update has happened yet.  Peter,
will you consider attempting to get this in for RTM?

Comment 7

[Peter Trudelle]

I can't repro, do you really need to have only 6 messages in your inbox, or at
least have all messages visible?  Even if not, this seems pretty obscure to me,
since reading mail without the message pane is poorly supported in this release,
and using shift-delete to delete them is itself obscure. Importing and deleting
buddies sound like rare operations as well. Finally, the result is cosmetic, and
there is a workaround. Given the current 'pull-it-off-the-wire' criteria, I have
to say rtm-/future.

Comment 8

[selmer (gone)]

Hmm.  I didn't mean to give the impression that I had made an exhaustive
analysis or listing of all the ways to repro this.  I gave steps that reproduce
it reliably for me on my machine.  I _have_ seen this happen several times in
various circumstances using mail and it doesn't seem to depend on having only a
few messages.  It probably _is_ related to deleting near the bottom of the
visible portion of the tree.  It _may_ or _may_not_ require the use of
shift-delete versus an unmodified delete.

I was hoping that QA could comment or look at the various possibilities before
we dismiss this.

Comment 9

[Peter Trudelle]

Oh, I thought we had steps to reproduce.  This is worth some testing, IMO, so
perhaps jrgm could find time for it in his busy schedule.

Comment 10

[scalkins]

Here is a test case where users in the field might encounter this bug more often.
On an ftp site, if your expanding  directory, the twistie will point down when
you click on it indicating the directory expanded, but you waon't see any
contents for the expanded directory unless you click on the twistie for the next
directory.
I tested this on our internal ftp site
ftp://sweetlou/products/client/seamonkey/windows/32bit/x86/
I clicked on the twistie for the diretcory 2000-10-20-06-Mtrunk, the twistie
moved, but the contents of the directory wouldn't show until I expoaned the
group under that one!
Then the one _above_ it shows (or you can drag the drenn

Comment 11

[esther]

Update: With 10-23 builds, I'm trying several scenarios for the mail window and
haven't been able to reproduce this with Deleteing.  However, I just did some
reading and scrolling and ended up with a blank Thread window.  I will
investigate more.  

Comment 12

[selmer (gone)]

I can also repro scalkins scenario 100% on today's build.

Comment 13

[David Hyatt]

The FTP thing is a totally different bug.  Don't confuse it with the tree 
getting confused on deletion.

Comment 14

[Peter Trudelle]

I've just learned of a scenario where the Buddy List display is not kept in
synch when buddies go offline, which is extremely common. marking rtm need info
to get a better handle on this.

Comment 15

[David Hyatt]

The patch attached for the other three rtm need info bugs fixes the case where
buddies go offline.  With the new patch, I'm finding it extremely hard to make
the tree get out of sync.  I think it's plugged some of the more common cases.

Comment 16

[scalkins]

The Aim tracking bug logged in Bugscape for status not updating for IM buddies is:
http://bugscape.netscape.com/show_bug.cgi?id=3016

Comment 17

[scalkins]

Addtnl note, the refresh bug for deleting aim buddies in the list is being
tracked in Bugscape as bug http://bugscape.netscape.com/show_bug.cgi?id=3031

Comment 18

[David Hyatt]

57139 improves deletion substantially.  See the patch there.

Comment 19

[Gervase Markham [:gerv]]

Is this problem still serious enough to merit a relnote, given that "the more 
common cases are plugged"?

The blurb:
It seems unclear to me whether this bug requires either of a "developer" or 
"user" release note for Netscape 6 RTM. If anyone feels it does, can they please 
draft one and then nominate with the relnote-user or relnote-devel strings in 
the Status Whiteboard.

Thanks :-)

Gerv

Comment 20

[Joe Hewitt (gone)]

I should note that I'm experiencing a problem like this whenever rows near the 
bottom of the tree are deleted or collapsed.  They simply do not repaint.  This 
only occurs for the very last row in the tree, or a contiguous set of rows that 
ends at the last row in the tree.  Perhaps the patch in 57139 will help this...

Comment 21

[David Hyatt]

Marking rtm+, since 57139 is now rtm+.

Comment 22

[David Hyatt]

Fixed.  Open new bugs on any specific problems you find now.  The more general
syncing problem has been addressed.