569797 - Change ID of left pane to not describe it as being the right pane

Status: VERIFIED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Spin-off from bug 563076. The left pane has an id of "right-pane". Obviously, this is somewhat incorrect.

Comment 1

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Attachment: Patch

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

https://hg.mozilla.org/mozilla-central/rev/db34fb54bbe0

Checked in with r=Mossop, as given in bug 563076.

Comment 3

[Dão Gottwald [:dao]]

An id using neither "left" nor "right" would be even better. Think RTL.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's true. Blair what about 'view-categories" so we have a similar name compared the the digest view?

Comment 5

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #4)
> That's true. Blair what about 'view-categories" so we have a similar name
> compared the the digest view?

There potentially could be other things added to that pane though - its not just for the category selectors. eg, the WiP patch in bug 567127 currently adds its UI to the bottom of that pane.

Comment 6

[Dave Townsend [:mossop]]

How about just "sidebar"?

Comment 7

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 585960 changed the layout so that box was no longer needed - its just the category list on the left side now.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to comment #7)
> Bug 585960 changed the layout so that box was no longer needed - its just the
> category list on the left side now.

Blair, are you sure you meant bug 585960?

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

But anyway this is fixed now by removing those nodes.

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

(In reply to comment #8)
> Blair, are you sure you meant bug 585960?

Bah. Apparently the checkin comment references the wrong bug number.

http://hg.mozilla.org/mozilla-central/rev/307a672ee758

Which is really bug 585950.