release_master.py shouldn't use release_config.py variables as global variables

RESOLVED FIXED

Status

Release Engineering
General
P5
normal
RESOLVED FIXED
8 years ago
5 years ago

People

(Reporter: rail, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [automation])

(Reporter)

Description

8 years ago
release_master.py uses "from release_config import *" to import release config variables. We have to set some variables (to None) even if we don't use them in the current release and these variables are optional or have sane default values in the corresponding classes.

Instead of using global variables we can use "import release_config" and then get the variables by getattr with sane fallback default values.
(Reporter)

Comment 1

7 years ago
Resolved by bug 553300
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.