Closed Bug 569828 Opened 14 years ago Closed 14 years ago

[e10s] isRootWindow checks can crash

Categories

(Firefox for Android Graveyard :: General, defect)

x86
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
The isRootWindow checks in bindings/browser.js can crash if aWebProgress.DOMWindow is null. Comparing to 'content' is better anyway.
Attachment #449005 - Flags: review?(21)
Comment on attachment 449005 [details] [diff] [review]
patch

I'm pretty sure you're looking for arguments to remove it! :)

Anyway, isRootWindow will dissapears in a few to be replace by the windowID check.
Attachment #449005 - Flags: review?(21) → review+
pushed to m-e10s:
http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/a5ee2ea1f719
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
bugspam
Assignee: nobody → mark.finkle
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: