Closed Bug 569839 Opened 10 years ago Closed 10 years ago

Port bug 569365 (kill preprocessor.pl) to comm-central

Categories

(MailNews Core :: Build Config, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Mitch, Assigned: Callek)

References

Details

Attachments

(1 file, 2 obsolete files)

Bug 569365 will remove preprocessor.pl, and use of it in comm-central needs to be switched to Preprocessor.py.
Where do we still use it? I though we have switched in most places already anyhow.
This does mail/* and calendar/*
Attachment #449181 - Flags: superreview?(philipp)
Attachment #449181 - Flags: review?(bugzilla)
Attached patch venkman v1 (obsolete) — Splinter Review
Of note here, is that m-c will be removing preprocessor.pl, and that the make-jars.pl presumes the preprocessor is written in perl. MakeJars.py does the same thing as make-jars.pl without needing some arguments (though the presence of the arguments will not cause MakeJars.py to fail, I decided to remove them while here)
Attachment #449183 - Flags: review?
Attachment #449183 - Flags: review? → review?(gijskruitbosch+bugs)
Attached patch venkman v2 (obsolete) — Splinter Review
Whops, didn't update the patch with both files.  Same comments as last patch apply.
Attachment #449183 - Attachment is obsolete: true
Attachment #449191 - Flags: review?(gijskruitbosch+bugs)
Attachment #449183 - Flags: review?(gijskruitbosch+bugs)
(In reply to comment #1)
> Where do we still use it? I though we have switched in most places already
> anyhow.

Just as a note on my own comment, everything left to port here is things that are not actually used in a SeaMonkey build process, that's why I thought we had switched most or all of it, as I did so successively in SeaMonkey patches. Thunderbird, calendar, and the make*xpi.sh scripts used to build extension XPI packages for venkman and ChatZilla have not seen all of that patch love, so that's what's left to do here. Thanks for picking that up.
(In reply to comment #5)
> (In reply to comment #1)
> > Where do we still use it? I though we have switched in most places already
> > anyhow.
> 
> Just as a note on my own comment, everything left to port here is things that
> are not actually used in a SeaMonkey build process, that's why I thought we had
> switched most or all of it, as I did so successively in SeaMonkey patches.
> Thunderbird, calendar, and the make*xpi.sh scripts used to build extension XPI
> packages for venkman and ChatZilla have not seen all of that patch love, so
> that's what's left to do here. Thanks for picking that up.

And actually when I went to patch cZ I realized the MXR hits were from |extensions/irc-cvs| and not the HG repo. So nothing to do there.
Attachment #449181 - Flags: superreview?(philipp) → review?(philipp)
Comment on attachment 449181 [details] [diff] [review]
main c-c v1 [checked-in]

r=philipp for calendar
Attachment #449181 - Flags: review?(philipp) → review+
Attachment #449181 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/3b861cce0e66

Still waiting on Gijs for venkman part
Attachment #449181 - Attachment description: main c-c v1 → main c-c v1 [checked-in]
Summary: Port bug 569365 to comm-central → Port bug 569365 (kill preprocessor.pl) to comm-central
Comment on attachment 449191 [details] [diff] [review]
venkman v2

(In reply to comment #8)
> http://hg.mozilla.org/comm-central/rev/3b861cce0e66
> 
> Still waiting on Gijs for venkman part

Yeah, sorry about that. Assuming you've tested this, r=me.
Attachment #449191 - Flags: review?(gijskruitbosch+bugs) → review+
Comment on attachment 449191 [details] [diff] [review]
venkman v2

Looks like this doesn't work quite like I had hoped, Gijs is updating this to be a py script instead of a shell script in another bug, so This patch is obsolete, and this bug is fixed.
Attachment #449191 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.