Closed
Bug 569984
Opened 15 years ago
Closed 15 years ago
Verify shader attachment/detachment and program object completeness
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
People
(Reporter: vlad, Assigned: vlad)
References
Details
Attachments
(1 file)
11.75 KB,
patch
|
bjacob
:
review+
|
Details | Diff | Splinter Review |
We need to ensure a few things about programs, represented in the newly written program-test. This ensures that:
1) We track attaches/detaches from program objects correctly;
2) We don't try to link a program unless it has both a vertex and fragment shader;
3) We don't allow any other type of shader to be created;
4) We don't allow using a program that has not been successfully linked;
5) We make draws silent no-ops when the null program is specified or used.
Attachment #449070 -
Flags: review?(bjacob)
Comment 1•15 years ago
|
||
Comment on attachment 449070 [details] [diff] [review]
track program objects more carefully
I can't see anything wrong!
Attachment #449070 -
Flags: review?(bjacob) → review+
Assignee | ||
Comment 2•15 years ago
|
||
Flags: in-testsuite+
Assignee | ||
Updated•15 years ago
|
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•