569984 - Verify shader attachment/detachment and program object completeness

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Attachment: track program objects more carefully

We need to ensure a few things about programs, represented in the newly written program-test.  This ensures that:

1) We track attaches/detaches from program objects correctly;

2) We don't try to link a program unless it has both a vertex and fragment shader;

3) We don't allow any other type of shader to be created;

4) We don't allow using a program that has not been successfully linked;

5) We make draws silent no-ops when the null program is specified or used.

Comment 1

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 449070 [details] [diff] [review]
track program objects more carefully

I can't see anything wrong!

Comment 2

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

http://hg.mozilla.org/mozilla-central/rev/f1d8218349ab