Don't use JS_ConstructObjectWithArguments in typed arrays

RESOLVED FIXED

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: vlad, Assigned: vlad)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 449114 [details] [diff] [review]
use ArrayBuffer::create directly

Andreas tells me this is bad, and indeed it is throwing us off trace.
Attachment #449114 - Flags: review?(gal)

Updated

8 years ago
Attachment #449114 - Flags: review?(gal) → review+
I didn't know until recently (a fuzz bug busting on one of my patches, fixed just today) that we LeaveTrace for any invocation, even of a native constructor. So I missed this reviewing the typed array code, I think.

Andreas, Jason: must we leave-trace for native calls and constructs?

/be
http://hg.mozilla.org/mozilla-central/rev/e7fac7e69d57
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.