570109 - _lazy string is not extracted for l10n

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Leszek Zyczkowski]

Not displayed localized string Featured and problems with Reviews section.
See https://addons.mozilla.org/pl/firefox/addon/2455/

Comment 1

[Jeff Balogh (:jbalogh)]

The Featured string on install buttons is marked like this:

    install_text = _lazy(u'Featured', 'install_button')

I think it's not picked up because we're calling _lazy and the extractor doesn't know that's an alias for ugettext.

The reviews section problem is bug 570064.

Comment 3

[James Socol [:jsocol, :james]]

Updated Tower to allow additional keywords, like _lazy():

http://github.com/clouserw/tower/commit/8d83de7939f

All that's left is adding a TOWER_KEYWORDS dict to settings.py, something like

TOWER_KEYWORDS = {
    '_lazy': None
}

but I don't have commit access to Zamboni anymore.

Comment 4

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/d46025b

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Still not seeing this on the various locales I've tested on next/preview; Wil, do you need to run a script to get translations into preview/next, or is this now automatic?

Comment 7

[Wil Clouser [:clouserw]]

It is far from automatic and I still need to do it