Closed Bug 570109 Opened 14 years ago Closed 14 years ago

_lazy string is not extracted for l10n

Categories

(addons.mozilla.org Graveyard :: Localization, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
5.11.8

People

(Reporter: leszekz, Assigned: jbalogh)

References

Details

Not displayed localized string Featured and problems with Reviews section.
See https://addons.mozilla.org/pl/firefox/addon/2455/
The Featured string on install buttons is marked like this:

    install_text = _lazy(u'Featured', 'install_button')

I think it's not picked up because we're calling _lazy and the extractor doesn't know that's an alias for ugettext.

The reviews section problem is bug 570064.
OS: Windows XP → All
Hardware: x86 → All
Target Milestone: --- → 5.11.1
Target Milestone: 5.11.1 → 5.12
Summary: Not displayed localized string Featured and problems with Reviews section → _lazy string is not extracted for l10n
Assignee: nobody → james
Updated Tower to allow additional keywords, like _lazy():

http://github.com/clouserw/tower/commit/8d83de7939f

All that's left is adding a TOWER_KEYWORDS dict to settings.py, something like

TOWER_KEYWORDS = {
    '_lazy': None
}

but I don't have commit access to Zamboni anymore.
Assignee: james → nobody
Assignee: nobody → jbalogh
Target Milestone: 5.12 → 5.11.8
http://github.com/jbalogh/zamboni/commit/d46025b
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Still not seeing this on the various locales I've tested on next/preview; Wil, do you need to run a script to get translations into preview/next, or is this now automatic?
It is far from automatic and I still need to do it
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.