Closed Bug 570121 Opened 15 years ago Closed 15 years ago

NS_ERROR_XPC_BAD_CONVERT_JS in xml:browser.loadURIWithFlags from xml:browser.loadURI from nsBrowserAccess.prototype._getBrowser

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

(Keywords: regression)

Attachments

(1 file)

call loadURIWithFlags
794 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review
LOAD_FLAGS_FROM_EXTERNAL ends up being used as nsIURI aReferrer http://hg.mozilla.org/mobile-browser/rev/4cfb4164ba20 introduced a regression to the function nsBrowserAccess.prototype._getBrowser [Exception... "Could not convert JavaScript argument arg 2 [nsIWebNavigation.loadURI]" nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 187" data: no] 1630 _getBrowser: function _getBrowser(aURI, aOpener, aWhere, aContext) { ... 1635 let loadflags = isExternal ? 1636 Ci.nsIWebNavigation.LOAD_FLAGS_FROM_EXTERNAL : ... 1649 let browser; ... 1657 browser = Browser.addTab("about:blank", true).browser; ... 1667 referrer = gIOService.newURI(location, null, null); ... 1669 browser.loadURI(aURI.spec, loadflags, referrer, null, null); The regressing code calls: 153 <method name="loadURI"> 154 <parameter name="aURI"/> 155 <parameter name="aReferrerURI"/> 156 <parameter name="aCharset"/> 157 <body> 158 <![CDATA[ 159 const nsIWebNavigation = Components.interfaces.nsIWebNavigation; 160 const flags = nsIWebNavigation.LOAD_FLAGS_NONE; 161 this.loadURIWithFlags(aURI, flags, aReferrerURI, aCharset); 167 <method name="loadURIWithFlags"> 168 <parameter name="aURI"/> 169 <parameter name="aFlags"/> 170 <parameter name="aReferrerURI"/> 171 <parameter name="aCharset"/> 172 <parameter name="aPostData"/> 173 <body> ... 187 this.webNavigation.loadURI(aURI, aFlags, aReferrerURI, aPostData, null); 250 void loadURI(in wstring aURI, 251 in unsigned long aLoadFlags, 252 in nsIURI aReferrer, 253 in nsIInputStream aPostData, 254 in nsIInputStream aHeaders); If we weren't called as "isExternal", we'd actually get NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL
Assignee: nobody → timeless
Status: NEW → ASSIGNED
Attachment #449244 - Flags: review?(mark.finkle)
Attachment #449244 - Flags: review?(mark.finkle) → review+
pushed to m-b: http://hg.mozilla.org/mobile-browser/rev/70dc9cf110b0 pushed to m-e10s: http://hg.mozilla.org/users/pavlov_mozilla.com/mobile-e10s/rev/78aee3cad9ec
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: