Open Bug 570166 Opened 15 years ago Updated 2 years ago

Window title shows wrong with Hebrew letters

Categories

(Core :: Widget, defect, P3)

Product:
Core
Component:
Widget
Platform:
Desktop
Unspecified
Type:
defect

Tracking

()

People

(Reporter: porton, Unassigned)

Details

(Keywords: rtl)

Attachments

(2 files)

The HTML file with which proper display fails
192 bytes, text/html
Details
gnome.png
84.49 KB, image/png
Details
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.9) Gecko/20100501 Iceweasel/3.5.9 (like Firefox/3.5.9) Build Identifier: The word "Iceweasel" (would be "Firefox" for the mainline version of Firefox) is shown in the window title between the word "Caviar" and a string in Hebrew language. This is clearly wrong. I'm unsure whether it is a bug of Firefox or my window manager Sawfish 1.3.5.2. Reproducible: Always Steps to Reproduce: Open this file: <html> <head> <meta http-equiv="Content-Type" content="text/html; charset=UTF-8"> <title>חנות און-ליין של פירות ים Caviar</title> </head> <body> <p>Test</p> </body> </html> Actual Results: The word "Iceweasel" (would be "Firefox" for the mainline version of Firefox) is shown between the word "Caviar" and a string in Hebrew language. Expected Results: The string "Iceweasel" (or "Firefox") should be at the left of window title.
I checked that the same bug persists with Metacity 2.30.1 window manager. So it is a bug of Firefox not a particular window manager.
Please try with the latest Firefox build from mozilla.org (http://nightly.mozilla.org/). (I'm on Mac, so can't easily try to reproduce.)
Keywords: rtl
So what we do is to just append " - %APPNAME%" to the page's title. Since that's all ASCII in your case, the resulting rendering is what you see given bidi reordering. Should we be putting some sort of bidi override chars before the stuff we append? In any case, this is UI code, not Core code.
Product: Core → Firefox
QA Contact: general → general
Status: UNCONFIRMED → NEW
Ever confirmed: true
(In reply to comment #4) > So what we do is to just append " - %APPNAME%" to the page's title. Since > that's all ASCII in your case, the resulting rendering is what you see given > bidi reordering. Should we be putting some sort of bidi override chars before > the stuff we append? > > In any case, this is UI code, not Core code. I'm afraid it's a bit more complex than that, because %APPNAME% itself could be RTL...
Hmm... In which case we'd want it to reorder with the title (if that's ASCII), yes... I'm not going to pretend to understand how this _should_ work. :(
Simon, are these a set of control chars which we can use that would take care of all the four possible combinations of LTR/RTL in page title/browser name?
I think we need to consider at least eight combinations: LTR/RTL in page title/browser name/window direction (which can be RTL in localized builds). That's assuming that if the page title is mixed direction, we only care about the direction of the last visible character.
(In reply to comment #8) > I think we need to consider at least eight combinations: LTR/RTL in page > title/browser name/window direction (which can be RTL in localized builds). > That's assuming that if the page title is mixed direction, we only care about > the direction of the last visible character. Yeah, that's true on Windows. :/ I suspect that we can't rely on the OS do a very good job in bidi reordering of characters, right? Although that might change when we actually take over drawing the titlebar ourselves...
Severity: normal → S3

This still reproduces in current versions. Feels like a widget issue

Severity: S3 → --
Component: General → Widget: Gtk
Product: Firefox → Core

Can you try different desktop environment like Gnome?
Thanks.

Flags: needinfo?(gregp)
Priority: -- → P3
Attached image gnome.png —

Reproduces in GNOME 44.5

Flags: needinfo?(gregp)

So looks like Firefox bug then if you can reproduce in Gnome too. Looks like you need localized Firefox version as the "Mozilla Firefox" comes from the binary itself. Do you use Hebrew Firefox package with Hebrew localized strings in Menu?

Flags: needinfo?(gregp)

Do you use Hebrew Firefox package with Hebrew localized strings in Menu?

No.

Flags: needinfo?(gregp)
Component: Widget: Gtk → Widget
OS: Linux → Unspecified
Hardware: x86 → Desktop
Severity: -- → S4

This is reproducible also on Windows.
I think this should be fairly easy to fix, just append an RLM character or so to the window text before adding the brand name.
See the difference with it vs. without:
Without: https://tomer.github.io/pilcrow/?input=%D7%A0%D7%99%D7%A1%D7%99%D7%95%D7%9F%20Test%20-%20Firefox%20Nightly
With: https://tomer.github.io/pilcrow/?input=%D7%A0%D7%99%D7%A1%D7%99%D7%95%D7%9F%20Test%20%E2%80%8F-%20Firefox%20Nightly

Though I admit this smells like a bad idea.

Severity: S4 → --
Severity: -- → S4

I think you need to use localized Firefox build to have the titlebar in hebrew. Application name is hardcoded as well as menu entries etc.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: