57019 - window control menu doesn't work

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Casey Perkins]

I noticed sluggish performance on this issue a couple of months ago, but now it
doesn't work at all.
In Windows, in ANY application, you can press Alt-Space to get the window
control menu (Restore, Move, Size, Minimize, Maximize, Close). This is handy in
order to minimize or maximize a window without reaching for the mouse.
It doesn't work with Mozilla. You can click and get the window control menu
(which defeats the purpose), but the normal keyboard command doesn't work.

Comment 1

[Casey Perkins]

sorry, should probably be under keyboard navigation rather than browser general...

Comment 2

[Doron Rosenberg (IBM)]

reassigning

Comment 3

[don]

Dan, I think this is a toolkit issue ...

Comment 4

[Erich 'Ricky' Iseli]

This bug was still unconfirmed. Since it exists, changing state to New.

Comment 5

[Dan M]

This happens because we're consuming all keyboard events, including WM_SYSCHAR, 
since we handle menu keyboard equivalents ourselves. We'd get the system menu if 
we let alt-space messages pass through:

--- nsWindow.cpp-3.296	Thu Oct 26 14:58:42 2000
+++ nsWindow.cpp	Thu Oct 26 14:56:46 2000
@@ -2836,6 +2836,9 @@
             unsigned char    ch = (unsigned char)wParam;
             UINT            char_result;
   
+            // pass alt-space through to the default windowproc
+            if (mIsAltDown && ch == ' ')
+              break;
             //
             // check first for backspace or return, handle them specially 
             //

Of course, this would preclude ever capturing alt-space in any keyboard binding 
for our own purposes. Better perhaps to only let the event pass on if we don't 
have a binding for it, though I don't know how to do that offhand. cc:ing menu 
widget and event folk for comment.

Comment 6

[Doron Rosenberg (IBM)]

possibly related or dupe of 19328?

Comment 7

[timeless]

So this patch looks good, is there any reason not to use it?

Comment 8

[Fabian Guisset]

Please consider Doron's comment about this being a dup of bug 19328.
If the patch looks good we could apply it to that specific bug 19328.
Fabian. 

Comment 9

[Dan M]

OK, obviously this one is a dupe of 19328. Note that bug claims the problem 
covered by this bug has been fixed (though in a comment made nearly a year ago). 
I believe I'll just check in the above patch, close this bug and let that one 
live on, since now it mostly complains about alt-then-space.

After thinking and talking about the above patch, we've decided it's probably 
useful. It will of course prevent any XUL alt-space key handler from working, but 
people should know better than to have alt-space key commands.

Once this is fixed, the next bug filed will be that with the system control menu 
open, no keyboard navigation can move from there to the window menubar menus. 
That problem will be similar to bug 19328's alt-then-space problem; I think we 
won't want to try to fix either.

Comment 10

[Blake Ross]

I checked in the patch in bug 19328; it looks like this one would prevent the 
app from handling ctrl+alt+space (although shift+alt+space should open the 
control menu also).  Marking this fixed, because I know we have another bug 
specifically on alt,space.

Comment 11

[sairuh (rarely reading bugmail)]

vrfy fixed --tested on winnt using 2001.05.02.12 moz bits.