Last Comment Bug 570205 - IsTargetEditable could use isContentEditable
: IsTargetEditable could use isContentEditable
Status: RESOLVED FIXED
[good first bug]
:
Product: SeaMonkey
Classification: Client Software
Component: UI Design (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1a3
Assigned To: Edmund Wong (:ewong)
:
:
Mentors:
Depends on: 458037
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-04 12:49 PDT by neil@parkwaycc.co.uk
Modified: 2010-06-25 09:58 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Changed the return to use IsContentEditable. (1.02 KB, patch)
2010-06-07 03:35 PDT, Edmund Wong (:ewong)
neil: review+
Details | Diff | Splinter Review
Changed the return to use IsContentEditable. [Checkin: comment 4] (1.02 KB, patch)
2010-06-07 06:38 PDT, Edmund Wong (:ewong)
ewong: review+
Details | Diff | Splinter Review

Description neil@parkwaycc.co.uk 2010-06-04 12:49:00 PDT
Currently IsTargetEditable works by looking for an HTML element with a non-inherit value of the contentEditable property. The new isContentEditable property does much the same thing, although we still have to find an HTML element; once we do find one we can then return its editableness directly.
Comment 1 Edmund Wong (:ewong) 2010-06-07 03:35:14 PDT
Created attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.
Comment 2 neil@parkwaycc.co.uk 2010-06-07 03:42:37 PDT
Comment on attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.

>     for (var node = this.target; node; node = node.parentNode)
>       if (node instanceof Components.interfaces.nsIDOMNSHTMLElement)
>+         return node.isContentEditable;
[Nit: too much indentation. Please remove one space before checkin.]
Comment 3 Edmund Wong (:ewong) 2010-06-07 06:38:32 PDT
Created attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

Removed a space.
Comment 4 Jens Hatlak (:InvisibleSmiley) 2010-06-25 09:57:51 PDT
Comment on attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/a8b8bdb983aa

Note You need to log in before you can comment on or make changes to this bug.