Closed Bug 570205 Opened 10 years ago Closed 9 years ago

IsTargetEditable could use isContentEditable

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.1a3

People

(Reporter: neil, Assigned: ewong)

References

Details

(Whiteboard: [good first bug])

Attachments

(1 file, 1 obsolete file)

Currently IsTargetEditable works by looking for an HTML element with a non-inherit value of the contentEditable property. The new isContentEditable property does much the same thing, although we still have to find an HTML element; once we do find one we can then return its editableness directly.
Assignee: nobody → ewong
Status: NEW → ASSIGNED
Attachment #449595 - Flags: review?
Attachment #449595 - Flags: review? → review?(neil)
Comment on attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.

>     for (var node = this.target; node; node = node.parentNode)
>       if (node instanceof Components.interfaces.nsIDOMNSHTMLElement)
>+         return node.isContentEditable;
[Nit: too much indentation. Please remove one space before checkin.]
Attachment #449595 - Flags: review?(neil) → review+
Removed a space.
Attachment #449595 - Attachment is obsolete: true
Attachment #449612 - Flags: review+
Keywords: checkin-needed
Comment on attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/a8b8bdb983aa
Attachment #449612 - Attachment description: Changed the return to use IsContentEditable. → Changed the return to use IsContentEditable. [Checkin: comment 4]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.