IsTargetEditable could use isContentEditable

RESOLVED FIXED in seamonkey2.1a3

Status

SeaMonkey
UI Design
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: ewong)

Tracking

Trunk
seamonkey2.1a3

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Currently IsTargetEditable works by looking for an HTML element with a non-inherit value of the contentEditable property. The new isContentEditable property does much the same thing, although we still have to find an HTML element; once we do find one we can then return its editableness directly.
(Assignee)

Updated

7 years ago
Assignee: nobody → ewong
Status: NEW → ASSIGNED
(Assignee)

Comment 1

7 years ago
Created attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.
Attachment #449595 - Flags: review?
(Assignee)

Updated

7 years ago
Attachment #449595 - Flags: review? → review?(neil)
(Reporter)

Comment 2

7 years ago
Comment on attachment 449595 [details] [diff] [review]
Changed the return to use IsContentEditable.

>     for (var node = this.target; node; node = node.parentNode)
>       if (node instanceof Components.interfaces.nsIDOMNSHTMLElement)
>+         return node.isContentEditable;
[Nit: too much indentation. Please remove one space before checkin.]
Attachment #449595 - Flags: review?(neil) → review+
(Assignee)

Comment 3

7 years ago
Created attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

Removed a space.
Attachment #449595 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Attachment #449612 - Flags: review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Comment on attachment 449612 [details] [diff] [review]
Changed the return to use IsContentEditable. [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/a8b8bdb983aa
Attachment #449612 - Attachment description: Changed the return to use IsContentEditable. → Changed the return to use IsContentEditable. [Checkin: comment 4]
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1a3
You need to log in before you can comment on or make changes to this bug.