570240 - need a way to open a new window (and convert tests to use it)

Status: RESOLVED WONTFIX

(Add-on SDK Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

see bug 570223. that approach to opening new browser windows isn't working on trunk anymore. we should use openDialog for now.

also, the code to open new browser windows is being duplicated across a bunch of tests.

i propose we expose openNewBrowserWindow(callback [, url]) off of the window-utils module, for both tests and other modules to use.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: v1

patch for impl. once reviewed, i'll update all the tests.

Comment 2

[Drew Willcoxon :adw]

I see you've copied openBrowserWindow() from tab-browser.  tab-browser.addTab(), which is the only caller of openBrowserWindow, actually recognizes a |inNewWindow| option that forces the given URL to open in a new tab in a new window -- hence openBrowserWindow.  Could we just use that instead?

Comment 4

[Dietrich Ayala (:dietrich)]

(In reply to comment #2)
> I see you've copied openBrowserWindow() from tab-browser. 
> tab-browser.addTab(), which is the only caller of openBrowserWindow, actually
> recognizes a |inNewWindow| option that forces the given URL to open in a new
> tab in a new window -- hence openBrowserWindow.  Could we just use that
> instead?


yeah, we could just convert all the tests to use addTab("about:blank"), so WONTFIXing this.

calling tab-browser.addTab when you want open a new window seems a little more awkward than window-utils.openBrowserWindow, but there's no public case for doing so atm, so not going to worry about it for now.

Comment 5

[Drew Willcoxon :adw]

Might be worth defaulting to about:blank so you don't need to pass a URL if you don't care.

Comment 6

[Dietrich Ayala (:dietrich)]

the addTab + inNewWindow approach doesn't provide a way to get access to the tab, nor the window. this means you can't do things like close the tab, or close the window.

that might be ok if there was a way to get access to the currently active window, but there's not.

i can cobble together everything i need to do these things in the traditional fully privileged xpcom way (assuming tests will always be priv'd), but i think that sooner or later we're going to need to make windows as easily accessible as the tabs module will do for tabs.

Comment 7

[Dietrich Ayala (:dietrich)]

i'm using chrome apis in all the tests, which is fine. we'll figure out a proper window api in bug 571449.

-> WONTFIX

Comment 8

[Myk Melez [:myk] [@mykmelez]]

The Add-on SDK is no longer a Mozilla Labs experiment and has become a big enough project to warrant its own Bugzilla product, so the "Add-on SDK" product has been created for it, and I am moving its bugs to that product.

To filter bugmail related to this change, filter on the word "looptid".