Status

RESOLVED WONTFIX
8 years ago
2 years ago

People

(Reporter: sergeyreym, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; ru; rv:1.9.2.3) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3
Build Identifier: 

Memory leaks in submission element. This is showed in attached example.

Reproducible: Always

Steps to Reproduce:
1. Click on "Get Data" at least twice.
2. Close firefox.
3. In debug build you'll see very much leaks.
(Reporter)

Comment 1

8 years ago
Created attachment 449439 [details]
xmldata
(Reporter)

Comment 2

8 years ago
Created attachment 449440 [details]
testcase
(Reporter)

Updated

8 years ago
Attachment #449440 - Attachment mime type: text/html → text/xhtml
(Reporter)

Updated

8 years ago
Attachment #449440 - Attachment mime type: text/xhtml → text/html
(Reporter)

Comment 3

8 years ago
It's more efficient reduce this leaks and then reduce leaks of get-repeat.
Blocks: 312342
(Reporter)

Comment 4

8 years ago
Created attachment 452983 [details] [diff] [review]
patch 1

I've made this patch according Common leak patterns point 2.2 (https://wiki.mozilla.org/Performance:Leak_Tools#Common_leak_patterns).
Attachment #452983 - Flags: review?(Olli.Pettay)
(Reporter)

Comment 5

8 years ago
Created attachment 452998 [details] [diff] [review]
patch 1
Attachment #452983 - Attachment is obsolete: true
Attachment #452998 - Flags: review?(Olli.Pettay)
Attachment #452983 - Flags: review?(Olli.Pettay)

Updated

8 years ago
Attachment #452998 - Flags: review?(Olli.Pettay) → review-

Comment 6

8 years ago
Comment on attachment 452998 [details] [diff] [review]
patch 1

I don't understand this at all. 
GetModel returns already_AddRefed so when assigning to some nsCOMPtr<...> variable, there is no addreffing happening anyway.

Does the patch really change anything?
(Reporter)

Comment 7

8 years ago
Ooops, sorry. Indeed this patch doesn't reduce leaks.
RIP xforms
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 years ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.