User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; ru; rv:22.214.171.124) Gecko/20100423 Ubuntu/10.04 (lucid) Firefox/3.6.3 Build Identifier: Memory leaks in submission element. This is showed in attached example. Reproducible: Always Steps to Reproduce: 1. Click on "Get Data" at least twice. 2. Close firefox. 3. In debug build you'll see very much leaks.
Attachment #449440 - Attachment mime type: text/html → text/xhtml
Attachment #449440 - Attachment mime type: text/xhtml → text/html
It's more efficient reduce this leaks and then reduce leaks of get-repeat.
Created attachment 452983 [details] [diff] [review] patch 1 I've made this patch according Common leak patterns point 2.2 (https://wiki.mozilla.org/Performance:Leak_Tools#Common_leak_patterns).
Created attachment 452998 [details] [diff] [review] patch 1
Attachment #452998 - Flags: review?(Olli.Pettay) → review-
Comment on attachment 452998 [details] [diff] [review] patch 1 I don't understand this at all. GetModel returns already_AddRefed so when assigning to some nsCOMPtr<...> variable, there is no addreffing happening anyway. Does the patch really change anything?
Ooops, sorry. Indeed this patch doesn't reduce leaks.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.