Closed Bug 570329 Opened 15 years ago Closed 15 years ago

allow shorter variables in reftest sandbox for widget tests

Categories

(Testing :: Reftest, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.3a5

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files)

One comment complaint I've heard about the reftest manifest format is that fails-if(MOZ_WIDGET_TOOLKIT=="gtk2") is rather unwieldy. So I propose that we define 4 new variables in the reftest sandbox: cocoaWidget gtk2Widget qtWidget winWidget (and can add more in the future for new widget ports), such that one can instead write fails-if(gtk2Widget) for the same thing. I have a pair of patches to fix this (and once I do, I'd presumably mass-change the existing manifests, but I don't want to write that patch until it's ready to land).
Building the sandbox has come to take up a decent chunk of code; it should now be its own function for clarity.
Attachment #449462 - Flags: review?(roc)
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
I landed the mass change: http://hg.mozilla.org/mozilla-central/rev/ec0c1319fec3 ... but I should probably remove MOZ_WIDGET_TOOLKIT at some point as well.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: