570329 - allow shorter variables in reftest sandbox for widget tests

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

One comment complaint I've heard about the reftest manifest format is that fails-if(MOZ_WIDGET_TOOLKIT=="gtk2") is rather unwieldy.

So I propose that we define 4 new variables in the reftest sandbox:
  cocoaWidget
  gtk2Widget
  qtWidget
  winWidget
(and can add more in the future for new widget ports), such that one can instead write fails-if(gtk2Widget) for the same thing.


I have a pair of patches to fix this (and once I do, I'd presumably mass-change the existing manifests, but I don't want to write that patch until it's ready to land).

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 1: separate BuildConditionSandbox()

Building the sandbox has come to take up a decent chunk of code; it should now be its own function for clarity.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 2: add the widget shortcuts

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/f3d46038a794
http://hg.mozilla.org/mozilla-central/rev/f9e8bdcb48cd

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I landed the mass change:
http://hg.mozilla.org/mozilla-central/rev/ec0c1319fec3

... but I should probably remove MOZ_WIDGET_TOOLKIT at some point as well.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Landed the followup fix:
http://hg.mozilla.org/mozilla-central/rev/923e1109a1d0

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch 4: remove MOZ_WIDGET_TOOLKIT

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/2b2a00285cc9