Closed Bug 570329 Opened 11 years ago Closed 11 years ago

allow shorter variables in reftest sandbox for widget tests

Categories

(Testing :: Reftest, defect)

Product:
Testing
Component:
Reftest
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a5

People

(Reporter: dbaron, Assigned: dbaron)

Details

Attachments

(3 files)

patch 1: separate BuildConditionSandbox()
3.63 KB, patch
roc
: review+
Details | Diff | Splinter Review
patch 2: add the widget shortcuts
3.24 KB, patch
roc
: review+
Details | Diff | Splinter Review
patch 4: remove MOZ_WIDGET_TOOLKIT
1.09 KB, patch
roc
: review+
Details | Diff | Splinter Review 
One comment complaint I've heard about the reftest manifest format is that fails-if(MOZ_WIDGET_TOOLKIT=="gtk2") is rather unwieldy.

So I propose that we define 4 new variables in the reftest sandbox:
  cocoaWidget
  gtk2Widget
  qtWidget
  winWidget
(and can add more in the future for new widget ports), such that one can instead write fails-if(gtk2Widget) for the same thing.


I have a pair of patches to fix this (and once I do, I'd presumably mass-change the existing manifests, but I don't want to write that patch until it's ready to land).
Building the sandbox has come to take up a decent chunk of code; it should now be its own function for clarity.
Attachment #449462 - Flags: review?(roc)
Attachment #449463 - Flags: review?(roc)
http://hg.mozilla.org/mozilla-central/rev/f3d46038a794
http://hg.mozilla.org/mozilla-central/rev/f9e8bdcb48cd
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a5
I landed the mass change:
http://hg.mozilla.org/mozilla-central/rev/ec0c1319fec3

... but I should probably remove MOZ_WIDGET_TOOLKIT at some point as well.
Attachment #461746 - Flags: review?(roc)
You need to log in before you can comment on or make changes to this bug.