If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

TM: use an infallible, unlocked path to get reserved slots where we know its safe

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: gal, Assigned: gal)

Tracking

Other Branch
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

7 years ago
And inline to boot.
(Assignee)

Comment 2

7 years ago
Created attachment 449525 [details] [diff] [review]
patch
Assignee: general → gal
Attachment #449525 - Flags: review?(brendan)
Is there any need for the slot < numSlots() test or should we assert that condition instead?

/be
(Assignee)

Comment 4

7 years ago
I think freeslot is only moved by the first SetReservedSlot. I am not sure its generally true for all uses of reserved slots that they are always set before read.
Attachment #449525 - Flags: review?(brendan) → review+
(Assignee)

Comment 5

7 years ago
http://hg.mozilla.org/tracemonkey/rev/6ac9c370d16c
Whiteboard: fixed-in-tracemonkey

Comment 6

7 years ago
http://hg.mozilla.org/mozilla-central/rev/6ac9c370d16c
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.