570405 - nsAccEvent should deal with nsAccessible

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 2

[alexander :surkov (:asurkov)]

Attachment: patch2

fix failure on linux

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 449527 [details] [diff] [review]
patch2

r=me with comment (optional nits):

>+nsAccessible *
>+nsAccEvent::GetAccessible()
>+{
>+  if (!mAccessible)
>+    mAccessible = GetAccessibleByNode();
>+
>+  return mAccessible;
>+}
>+
> nsINode*
> nsAccEvent::GetNode()
> {
>-  if (!mNode) {
>-    nsRefPtr<nsAccessNode> accessNode(do_QueryObject(mAccessible));
>-    if (accessNode)
>-      mNode = accessNode->GetNode();
>-  }
>+  if (!mNode && mAccessible)
>+    mNode = mAccessible->GetNode();
> 
>   return mNode;
> }

For these you could just do:

return foo ? foo : bar->GetFoo();

Comment 4

[alexander :surkov (:asurkov)]

landed on 1.9.3 - http://hg.mozilla.org/mozilla-central/rev/28a9850ae772