Closed Bug 570436 Opened 9 years ago Closed 7 years ago

"ASSERTION: Different heights?" with testcase from bug 499885

Categories

(Core :: Layout: Form Controls, defect)

x86
Windows XP
defect
Not set

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jruderman, Unassigned)

Details

(Keywords: assertion, testcase)

On Windows, apparently the testcase for bug 499885 triggers:

###!!! ASSERTION: Different heights?: 'buttonHeight == displayHeight || (aReflowState.ComputedHeight() < buttonHeight && buttonHeight == mButtonFrame->GetUsedBorderAndPadding().TopBottom()) || (aReflowState.ComputedHeight() < displayHeight && displayHeight == mDisplayFrame->GetUsedBorderAndPadding().TopBottom())', file e:/builds/moz2_slave/tryserver-win32-debug/build/layout/forms/nsComboboxControlFrame.cpp, line 694

http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1275860246.1275861189.30811.gz&fulltext=1#err1
layout/generic/crashtests/499885-1.xhtml is marked as:

asserts(10-90) asserts-if(winWidget,18-108) load 499885-1.xhtml # nscoord_MAX 
    assertions (bug 575011), plus bug 570436 on windows
Jesse do you think this is the same as what I am seeing for Win7 debug unit tests?
https://bugzilla.mozilla.org/show_bug.cgi?id=614956#c5

> REFTEST TEST-UNEXPECTED-PASS | file:///c:/talos-slave/mozilla-central_win7-debug_test-crashtest/build/reftest/tests/layout/generic/crashtests/499885-1.xhtml | assertion count 3 is less than expected 18 to 108 assertions
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1291229629.1291230792.27015.gz

I enabled yesterday Win7 debug unit tests. Win7 debug crashtests are hidden from tbpl but they can be seen with &noignore=1
Looks like that run is complaining about seeing *fewer* assertions than expected. Expand the range if you want.
Seems like this isn't happening on Win7. Assertion count adjusted in bug 615959.
WFM, m-c local debug builds on Linux64 and OSX.  The remaining assertions are
about nscoord_MAX arithmetics that really should be demoted to warnings.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.