570447 - Height of About dialog is broken, both conceptually and literally

Status: RESOLVED WORKSFORME

(Firefox :: General, defect)

Description

[Phil Ringnalda (:philor)]

STR:
1. Use an official build of Firefox from after I added a few words to the About dialog in bug 569057.
2. Tell Windows to use Extra Large fonts.
3. Open the About dialog, and wonder where your UA string went.

Apparently we determine the height of the dialog by choosing a random number of pixels for the min-height of the deck in http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.css#10 which we somehow think might be more than the height of the longest text (which of course we don't know, since even when we know about the text in official builds, we don't know about the text in official builds in every locale, much less that text plus the text that's added in partner repacks) in whatever we decide is the largest system font size that we think a user might choose without us deciding that he's beyond caring about.

That's broken.

Comment 1

[mcdavis941 (sporadically reading bugmail)]

Also, related bug 427047.

Comment 2

[[not reading bugmail]]

There were some similar fixes for the app update dialogs for l10n support of larger, longer text, maybe that work is useful here?

Comment 3

[Phil Ringnalda (:philor)]

Go go gadget rewrite!