Background Tab Close buttons disappear

RESOLVED FIXED

Status

Firefox Graveyard
Panorama
P4
normal
RESOLVED FIXED
8 years ago
2 years ago

People

(Reporter: Brian Polidoro, Assigned: raymondlee)

Tracking

Trunk
x86
Windows XP

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
Tab close buttons disappear after using Tab Candy.

STR.

1. Open a few tabs.  Note the tab close buttons are there.
2. Open tab candy with the toolbar button.
3. Select a tab to close Tab Candy.

Then the tab close buttons are gone.

Tab Candy 0.3.8.
(Reporter)

Comment 1

8 years ago
Err I meant only the background tab close buttons are missing.  It's like having too many tabs opened so that the background tab close buttons are hidden to save space.  Yet in my test I only had three tabs open overall.
Summary: Tab Close buttons disappear → Background Tab Close buttons disappear
I believe the tab close buttons in question are in the tabs in the tabbar, not in the tab candy interface. I imagine this has to do with the fact that there are actually a number of tabs in the system, so it goes over its "must hide buttons to save space" threshold, even though we're hiding most of the tabs, so we don't really need to save space.
Assignee: nobody → raymond
Priority: -- → P4
(Assignee)

Comment 3

8 years ago
Fx shows tab close buttons based on the "closebuttons" attribute on the tabContainer.  Currently, the tabCandy is the first tab in the tabContainer and it's collapsed, hence its witdth is 0.  The Fx adjustTabStrip() uses the width of the first tab to determine whether to show the tab close buttons on background tabs, therefore, we have this issue.  We are going to move the tabCandy out of a tab (bug 572889) so this issue will disappear.

Ref: adjustTabstrip() 
http://mxr.mozilla.org/comm-1.9.2/source/mozilla/browser/base/content/tabbrowser.xml#3050
(Assignee)

Comment 4

8 years ago
Created attachment 452689 [details] [diff] [review]
Patch for this bug

After thinking about this more, I see that we still have the issue after moving the tabCandy out of the first tab.  I've created a temp fix for the issue but when the tabCandy is merged to the Firefox source, the adjustTabStrip() in the tabbrowser.xml should be modified to address the issue.
I've applied the patch: http://hg.mozilla.org/labs/tabcandy/rev/c75c6e0c2683

I also caught a couple additional cases: http://hg.mozilla.org/labs/tabcandy/rev/325c245b17da

Thanks, Raymond!
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED

Comment 6

8 years ago
Mass moving all Tab Candy bugs from Mozilla Labs to Firefox::Tab Candy.  Filter the bugmail spam with "tabcandymassmove".
Component: TabCandy → TabCandy
Product: Mozilla Labs → Firefox
Target Milestone: -- → ---
Version: unspecified → Trunk
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.