570617 - Review count does not update when all of an add-on's reviews are removed

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[krupa raj[:krupa]]

user agent:Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.3) Gecko/20100401 Firefox/3.6.3

steps to reproduce:
1.go to https://preview.addons.mozilla.org/en-US/firefox/addon/6028/
2.notice that this add-on has 106 reviews
3.click to view all the reviews.

expected result:
-There is a Reviews section in the add-on detail page,where at least three reviews are featured.
-There is a link to all review page

actual result:
The reviews section is missing
There is no link to the all reviews page.

Comment 1

[Jeff Balogh (:jbalogh)]

This add-on has no reviews.  I suspect that the author deleted old versions.

The review count hasn't been reset because the query in maintenance.php does an INNER JOIN on reviews.  This add-on has 0 reviews, so there won't be a row for it and it never gets updated.

Comment 2

[Jeff Balogh (:jbalogh)]

http://github.com/jbalogh/zamboni/commit/2c4525a7b gets this right.

QA: this cronjob runs at 2am, so check back tomorrow.

Comment 3

[Jeff Balogh (:jbalogh)]

Fixed real good in http://github.com/jbalogh/zamboni/commits/de9ec8e.

Check it tomorrow.

Comment 4

[krupa raj[:krupa]]

not fixed yet.Reopening https://preview.addons.mozilla.org/en-US/firefox/addon/6028/#reviews

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Jeff, the whole host of these bugs was fixed by the re-updating of the non-updating cron, right?

Comment 6

[Jeff Balogh (:jbalogh)]

yessir, the fancy new cron wasn't getting run (bug 574837).

Comment 7

[krupa raj[:krupa]]

Will verify this bug once bug 557879 is fixed