570636 - Decide how to co-exist as a sync add-on and built-in sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[Ed Lee :Mardak]

Eventually when sync is part of the platform, the add-on needs to still install/work if it adds new functionality over what's provided by the platform.

Comment 1

[Mike Connor [:mconnor]]

Things to do:

chrome:

make chrome registration for UI pieces only happen for appversion <= last_version_without_sync

components:

XPCOM magic

modules:

resource:// override (will change from weave to sync-services) will Just Work

Comment 2

[Ed Lee :Mardak]

Attachment: v1 map to services-sync

Comment 3

[Ed Lee :Mardak]

Attachment: v1 appversion

I just pulled 3.7b1pre and 2.0b1pre out of nowhere! I'll poke mobile and firefox people..

Comment 4

[Ed Lee :Mardak]

We'll need to figure out what to do with options.xul too..

Oh and preferences.

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 451367 [details] [diff] [review]
v1 appversion

Can you make these values definable in the Makefile?  I suspect we'll need to update this version at least once.

Comment 6

[Ed Lee :Mardak]

Attachment: v2 appversion

More subst magic!

Comment 7

[Ed Lee :Mardak]

Attachment: v2 appversion

Comment 8

[Tony Chung [:tchung]]

how to test this against client?   just make sure they both still work at a smoketest level when both are running?

Comment 9

[Mike Connor [:mconnor]]

Well, there won't be "both" so much, but yes.  Duplicate UI, etc, is bad, broken sync is bad.  For Fennec, UI + add-on UI in prefs would be bad, etc.

Comment 10

[Ed Lee :Mardak]

Attachment: v1 prefs migration

Comment 11

[Mike Connor [:mconnor]]

Comment on attachment 451646 [details] [diff] [review]
v1 prefs migration


>+  _migratePrefs: function _migratePrefs() {
>+    // No need to re-migrate
>+    if (Svc.Prefs.get("migrated", false))
>+      return;
>+
>+    // Grab the list of old pref names
>+    let oldPrefBranch = "extensions.weave.";
>+    let oldPrefNames = Cc["@mozilla.org/preferences-service;1"].
>+                       getService(Ci.nsIPrefService).
>+                       getBranch(oldPrefBranch).
>+                       getChildList("", {});
>+
>+    // Map each old pref to the current pref branch
>+    let oldPref = new Preferences(oldPrefBranch);
>+    for each (let pref in oldPrefNames)
>+      Svc.Prefs.set(pref, oldPref.get(pref));
>+
>+    // Remove all the old prefs and remember that we've migrated
>+    oldPref.reset(oldPrefNames);

don't do this, call resetBranch on oldPrefBranch (just need to cache the branch you get earlier, and reuse here).

otherwise, r+

Comment 12

[Ed Lee :Mardak]

http://hg.mozilla.org/services/fx-sync/rev/5b7eb60105d3
Map the modules directory to services-sync instead of weave and update imports. 

http://hg.mozilla.org/services/fx-sync/rev/e32234bb73b7Only overlay Firefox before 3.7b1pre and Fennec before 2.0b1pre using @subst@. 

http://hg.mozilla.org/services/fx-sync/rev/f78c411eefac
Migrate prefs from extensions.weave. to services.sync. when loading the service for the first time before migration.