570680 - Remove call to check-locales.pl for Firefox

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

This was added in  to let localizers know that they needed to change ${BrandShortName} to $BrandShortName and ${BrandFullName} to $BrandFullName instead of changing the string names. iirc SeaMonkey and Thunderbird only have one release that uses check-locales.pl so I don't want to remove it from the tree at this time.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Looking at the Firefox review requirements it appears that only Shaver, Gavin, and yourself can review this change... :(

Comment 2

[Robert Strong (they/them - no direct email)]

Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/ab2882dd564c

Comment 3

[Robert Strong (they/them - no direct email)]

Pushed a followup bustage fix
http://hg.mozilla.org/mozilla-central/rev/fb55d93295ad

Turns out that the makefile was refactored in bug 458014 that also caused all platforms to test the Windows installer locale files... meh

Comment 4

[Axel Hecht [:Pike]]

hrm.

http://mxr.mozilla.org/l10n-central/search?string=%24\{BrandShortName\}&find=browser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central shows that there are some obsolete localizations in our repos that still use the old syntax. If they ever get picked up from where they are today, we'll miss these tests.

Comment 5

[Robert Strong (they/them - no direct email)]

Filed bug 582492 with patches for this.