Closed Bug 570680 Opened 12 years ago Closed 12 years ago

Remove call to check-locales.pl for Firefox

Categories

(Firefox :: Installer, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 4.0b1

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

References

Details

Attachments

(1 file)

This was added in  to let localizers know that they needed to change ${BrandShortName} to $BrandShortName and ${BrandFullName} to $BrandFullName instead of changing the string names. iirc SeaMonkey and Thunderbird only have one release that uses check-locales.pl so I don't want to remove it from the tree at this time.
Attached patch patchSplinter Review
Looking at the Firefox review requirements it appears that only Shaver, Gavin, and yourself can review this change... :(
Assignee: nobody → robert.bugzilla
Status: NEW → ASSIGNED
Attachment #449830 - Flags: review?(vladimir)
Pushed to mozilla-central
http://hg.mozilla.org/mozilla-central/rev/ab2882dd564c
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a6
Pushed a followup bustage fix
http://hg.mozilla.org/mozilla-central/rev/fb55d93295ad

Turns out that the makefile was refactored in bug 458014 that also caused all platforms to test the Windows installer locale files... meh
hrm.

http://mxr.mozilla.org/l10n-central/search?string=%24\{BrandShortName\}&find=browser%2Finstaller&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-central shows that there are some obsolete localizations in our repos that still use the old syntax. If they ever get picked up from where they are today, we'll miss these tests.
Filed bug 582492 with patches for this.
You need to log in before you can comment on or make changes to this bug.