570705 - When searchfield widget is too big, fallback on textfield

Status: NEW

(Core :: Widget: Cocoa, defect)

Description

[Mounir Lamouri (:mounir)]

Our Cocoa implementation for -moz-searchfield is ugly when too big because it's scaled from a specific size. In addition, the margin at the left doesn't change when the widget is scaled which is pretty ugly too.

What seems to be a clean solution would be to fallback on textfield widget when the searchfield one doesn't feel conveniant. It would be quite easy to draw a a textfield instead of a searchfield depending on the size of the frame. However, we would have to not apply the searchfield specific margin.

By the way, I've seen Webkit isn't using the same widget: theirs is a round corner field without the magnyfying glass. What is, for the platform, the semantic difference between them ?

Comment 1

[Markus Stange [:mstange]]

(In reply to comment #0)
> By the way, I've seen Webkit isn't using the same widget: theirs is a round
> corner field without the magnyfying glass. What is, for the platform, the
> semantic difference between them ?

I don't know why Webkit doesn't draw the magnifying glass. On Mac all round textfields are searchfields and have a magnifying glass; in other words, the difference is that the field without magnifying glass doesn't exist. :-)

Comment 2

[Mounir Lamouri (:mounir)]

(In reply to comment #1)
> (In reply to comment #0)
> > By the way, I've seen Webkit isn't using the same widget: theirs is a round
> > corner field without the magnyfying glass. What is, for the platform, the
> > semantic difference between them ?
> 
> I don't know why Webkit doesn't draw the magnifying glass. On Mac all round
> textfields are searchfields and have a magnifying glass; in other words, the
> difference is that the field without magnifying glass doesn't exist. :-)

I realized the search field without the magnifying glass is only used in spotlight-like search field. I guess Safari is using this widget instead of the widget with the magnifying glass.