Closed Bug 570720 Opened 14 years ago Closed 14 years ago

Intermittent failure in browser_library_search.js when default livemark feed includes "dummy"

Categories

(Firefox :: Bookmarks & History, defect)

Product:
Firefox
Component:
Bookmarks & History
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: philor, Assigned: adw)

References

Details

(Keywords: intermittent-failure, Whiteboard: [test disabled])

Attachments

(1 file)

patch
3.45 KB, patch
mak
: review+
Details | Diff | Splinter Review 
The searches in http://mxr.mozilla.org/mozilla-central/source/browser/components/places/tests/browser/browser_library_search.js assume that searching for "dummy" will return the test bookmark, but when the default live bookmark feed includes something like http://news.bbc.co.uk/2/hi/scotland/edinburgh_east_and_fife/10264909.stm - "Woman jailed for giving baby methadone-soaked dummy" then it finds that instead. It needs to switch to searching for something unique, which will never occur in the feed.
test disabled:

http://hg.mozilla.org/mozilla-central/rev/3347c14893e2
Whiteboard: [orange] → [orange][test disabled]
Assignee: nobody → adw
Status: NEW → ASSIGNED
Attached patch patch — — Splinter Review 
This works on an old build I have.  Let me pull, rebuild, and make sure it still works.  Instead of assuming the "dummy" node is the first row in the tree, it only checks that it exists in the tree at all.
Attachment #449900 - Flags: review?(mak77)
Comment on attachment 449900 [details] [diff] [review]
patch

Hm, comments in this bug are crazy long... a bug in tbpushlog bot?
Attachment #449900 - Flags: review?(mak77) → review+
Nope, tbplbot is doing exactly what he wants to do, commenting with every line that the errorparser said was a TEST-UNEXPECTED-FAIL. Bug 569965 agrees with you that not every single leaked object really needs to be a TEST-UNEXPECTED-FAIL when we leak the world, though.
http://hg.mozilla.org/mozilla-central/rev/81c4ee650d5e
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [orange][test disabled] → [test disabled]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: