570736 - Split bindings/browser.xml into a local-browser and remote-browser bindings

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Since we will use message manager APIs for non-e10s and e10s browsers, we need to support the core message based APIs in a base browser binding and then inherit the remote browser binding from it.

In the future, we'll look at moving the core message based API binding into toolkit/browser.xml, but for now it's faster and safer for Fennec to keep this binding local.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The patch also removes some methods we haven't overriden from the local, core binding.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed to m-b:
http://hg.mozilla.org/mobile-browser/rev/fa191f695f1a

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

After applying a few patches on top of this change, and thinking ahead to supporting local and remote pages in a single app, we might need to:

* Add full _webProgress support in local-browser since we want the exact same callbacks used for local (about: pages) and remote (web content pages). We can remove the _webProgress from the remote-browser since it inherits it from local-browser.
* Add full _webNavigation support in local-browser for the same reason as above. The code paths for local and remote browsers should be the same.

The only reason to keep the local-browser is some properties _will_ work (contentWindow and contentDocument), but can't in remote-browser.

I'll file a new bug

Comment 4

[Dão Gottwald [::dao]]

bugspam