570749 - Sniff user-agent server-side

Status: VERIFIED FIXED

(Input :: General, defect, P1)

Description

[Fred Wenzel [:wenzel]]

Currently we expect the User-Agent string to be provided as a GET parameter through the feedback extension. Instead, we should parse it server-side. If that does not work, we could also sniff it via JS.

Comment 1

[Aakash Desai [:aakashd]]

Just a FYI,

Here's a site tons of user agents (includes, spam bots, crawlers, robots and browsers) to send to download beta page:

http://www.user-agents.org/

Also, when a user types in the url for submission pages, we should sniff if it's the latest beta. If it is, show the submission page. If not, then show the download beta page.

Comment 2

[Aakash Desai [:aakashd]]

Also, when a user goes to /happy or /sad without having the user agent or URL parameters, then we should point them to the download page

Comment 3

[Fred Wenzel [:wenzel]]

Done: http://github.com/fwenzel/reporter/commit/2fe4de8

Note: When visiting the feedback forms, you can now omit the ua=... GET parameter. It'll be fished out of the request headers and validated. If you don't send a UA header or it's not from the latest beta, you get forwarded to the "need beta" page.

Comment 4

[Aakash Desai [:aakashd]]

verified FIXED