570911 - WebM (VP8) Landing broke pymake at running of yasm2masm-as.sh

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, minor)

Description

[Justin Wood (:Callek)]

Justin@DELLXPS400-1 /c/t/obj/media/libvpx
$ python -O ../../../src/build/pymake/make.py -j1
make.py[0]: Entering directory 'c:\t\obj\media\libvpx'
make.py[1]: Entering directory 'c:\t\obj\media\libvpx'
evaluation from c:\t\src\config\rules.mk:1621:42:3:0$ c:/t/obj/config/nsinstall.exe -m 644 ../../../
src/media/libvpx/vpx/vp8.h ../../../src/media/libvpx/vpx/vp8cx.h ../../../src/media/libvpx/vpx/vp8dx
.h ../../../src/media/libvpx/vpx/vp8e.h ../../../src/media/libvpx/vpx/vpx_codec.h ../../../src/media
/libvpx/vpx/vpx_codec_impl_bottom.h ../../../src/media/libvpx/vpx/vpx_codec_impl_top.h ../../../src/
media/libvpx/vpx/vpx_decoder.h ../../../src/media/libvpx/vpx/vpx_decoder_compat.h ../../../src/media
/libvpx/vpx/vpx_encoder.h ../../../src/media/libvpx/vpx/vpx_image.h ../../../src/media/libvpx/vpx_me
m/include/vpx_mem_intrnl.h ../../../src/media/libvpx/vpx_mem/vpx_mem.h ../../../src/media/libvpx/vpx
_ports/config.h ../../../src/media/libvpx/vpx_ports/mem.h ../../../src/media/libvpx/vpx/vpx_integer.
h ../../../src/media/libvpx/vpx_ports/vpx_timer.h ../../../src/media/libvpx/vpx_ports/x86.h ../../..
/src/media/libvpx/vpx_scale/scale_mode.h ../../../src/media/libvpx/vpx_scale/vpxscale.h ../../../src
/media/libvpx/vpx_scale/yv12config.h ../../../src/media/libvpx/vpx_scale/yv12extend.h ../../dist/inc
lude/vpx
make.py[1]: Leaving directory 'c:\t\obj\media\libvpx'
make.py[1]: Entering directory 'c:\t\obj\media\libvpx'
c:\t\src\config\rules.mk:1409:0$ ../../../src/media/libvpx/yasm2masm-as.sh -o idctllm_mmx.obj  -I../
../../src/media/libvpx/ -I../../../src/media/libvpx/vpx_ports/ -c c:/t/obj/media/libvpx/../../../src
/media/libvpx/vp8/common/x86/idctllm_mmx.asm
[Error 8] %1 is not a valid Win32 application
c:\t\src\config\rules.mk:1409:0: command '../../../src/media/libvpx/yasm2masm-as.sh -o idctllm_mmx.o
bj  -I../../../src/media/libvpx/ -I../../../src/media/libvpx/vpx_ports/ -c c:/t/obj/media/libvpx/../
../../src/media/libvpx/vp8/common/x86/idctllm_mmx.asm' failed, return code -127
c:\t\src\config\rules.mk:727:0: command 'c:/Programming/mozilla-build/python25/python.exe c:/t/src/b
uild/pymake/pymake/../make.py libs' failed, return code 2

Comment 1

[Justin Wood (:Callek)]

To help narrow the root issue down to anyone looking:

$(AS) evals to ${srcdir}/media/libvpx/yasm2masm-as.sh

Which pymake then tries to execute. Python in MozillaBuild being a windows program doesn't know how to execute yasm2masm-as.sh which of course, causes the "is not a valid Win32 application" error.

I'm a bit overtired so can't think on the right fix, if someone can name it I can write it up, or at least test.

Given then number of failures, I wonder if [in a followup] we should see about getting one builder to build with pymake both on trunk m-c and try. (even if it doesn't upload packages).

Comment 2

[[e-mail]]

Sprinkling some $(SHELL) love around might help.

Comment 3

[(not currently active) Ted Mielczarek]

Yeah, I suspect setting it to $(SHELL) $(srcdir)/media/libvpx/yasm2masm-as.sh will make it work just fine.

Comment 4

[Marco Bonardo [:mak]]

what is working for me so far:
VPX_AS='$(SHELL) $(topsrcdir)/media/libvpx/yasm2m~1.sh'

notice the shortened name, It was complaining about file not found with yasm2masm-as.sh :(

Comment 5

[Marco Bonardo [:mak]]

Attachment: patch v1.0

using $(SHELL) was trying to use "c:/mozilla-build/msys/bin/sh" that was causing the above error. Directly invoking "sh" solves the problem and allows me to build with make or pymake so far.

Comment 6

[Chris Pearce [:cpearce (GMT+13)]]

http://hg.mozilla.org/mozilla-central/rev/8cc8e86e725a

Comment 7

[[e-mail]]

This might fix things for me too... not only did yasm2masm-as.sh pull as non-executable, it begins #!/bin/bash but my bash doesn't live in /bin .