570932 - libvpx fails to build in yasm command

Status: RESOLVED WORKSFORME

(Core :: Audio/Video, defect)

Description

[Wolfgang Rosenauer [:wolfiR]]

I'm trying to build m-c on Linux x86 and get the following error:

yasm -o idctllm_mmx.o -f elf32 -rnasm -pnasm -I/usr/src/packages/BUILD/mozilla/media/libvpx/ -I/usr/src/packages/BUILD/mozilla/media/libv
px/vpx_ports/ -c /usr/src/packages/BUILD/mozilla/media/libvpx/vp8/common/x86/idctllm_mmx.asm
yasm: warning: unrecognized option `-c'
/usr/src/packages/BUILD/mozilla/media/libvpx/vpx_ports/x86_abi_support.asm:112: cannot reference symbol `CONFIG_PIC' in preprocessor

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Your YASM is out of date, update it to 1.0.1: http://www.tortall.net/projects/yasm/ Old versions don't define elf32, which is required in vpx_config.asm in order to include the write config file (vpx_config_x86-linux-gcc.h) which defines CONFIG_PIC.

Comment 2

[Wolfgang Rosenauer [:wolfiR]]

I cannot update yasm as I'm doing distribution builds which need to build on the distribution baseline.
Anyway I've made a quick fix but currently it would mean that it's not possible to create proper Linux distribution builds without patching for openSUSE 11.2 and below (which is the complete set as openSUSE 11.3 will only be released in July. (I know that this is a non-issue for you/upstream but still annoying.)

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

What version of YASM is the distribution baseline on openSUSE?

So, to be clear, on openSUSE if you execute: `sudo zypper install yasm`, you don't get a yasm which can build the assembly? That means our build instructions for Linux are wrong ([https://developer.mozilla.org/En/Developer_Guide/Build_Instructions/Linux_Prerequisites].

We should probably just add a --disable-webm-asm configure option.

Comment 4

[Wolfgang Rosenauer [:wolfiR]]

(In reply to comment #3)
> What version of YASM is the distribution baseline on openSUSE?

0.6.2 in all maintained releases.
11,3 will have 0.8.0 which seems to work.
 
> So, to be clear, on openSUSE if you execute: `sudo zypper install yasm`, you
> don't get a yasm which can build the assembly? That means our build
> instructions for Linux are wrong
> ([https://developer.mozilla.org/En/Developer_Guide/Build_Instructions/Linux_Prerequisites].

Yes, that's not going to work on i586. (Works with x86-64 though as yasm isn't used there)

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

I have updated the build instructions for openSUSE to say that you must download and build YASM manually. I have also specified a minimum YASM version in the "all other systems" section.