57095 - User/Password is not remembered when using keys to navigate in "password window" (space doesn't fire onCommand for checkboxes)

Status: RESOLVED WORKSFORME

(SeaMonkey :: UI Design, defect, P3)

Description

[Eugene Savitsky]

Open a passwod protected site.

Enter name, password, TAB to "remember my password" (or how calls it?), press
Space to activate the "remember button", TAB to OK, you entered the site.

When entering the same site second time (new session?) the same _blank_
user/password dialog appears.

With mouse click on the "remember button" all works fine.

Comment 1

[Doron Rosenberg (IBM)]

what build are you using?

Comment 2

[Eugene Savitsky]

I just tested it with 2000101904-Mtrunk.

Acctually it never worked with keyboard.

Comment 3

[Asa Dotzler [:asa]]

over to keyboard nav.

Comment 4

[sairuh (rarely reading bugmail)]

password manager bug? if not, punt back (or, punt to appropriate owner ;).

Comment 5

[Stephen P. Morse]

Punting back.

What reporter is saying is when he gets the password-manager dialog and checks 
off the box to "remember this decision", everything works fine.  But if instead 
of checking it off, he tabs to it and presses space, it doesn't remember the 
password.  I just tried it and was able to reproduce the behavior.

So this would be a generalized xul issue and not at all restricted to the 
password-manager dialog.  Any dialog created with universalDialog that contains 
a checkbox would have the same problem.  Namely the returned argument indicating 
the state of the checkbox will not be correct if the user checked the box with 
the tab and space keys as indicated.

Comment 6

[Blake Ross]

This is strange; hyatt, any ideas?

Comment 7

[Peter "jag" Annema]

commonDialog.xul:

      <!-- checkbox -->
      <box id="checkboxContainer" collapsed="true" autostretch="never">
        <checkbox id="checkbox" oncommand="onCheckboxClick(this)" 
style="max-width: 40em;"/>
      </box>

commonDialog.js:

function onCheckboxClick(aCheckboxElement)
{
  gCommonDialogParam.SetInt(1, aCheckboxElement.checked);
}

I guess oncommand isn't called when you press space. Should an onkeypress be 
added, or should we make pressing space call oncommand in xulBindings.xml?

Comment 8

[Viswanath Ramachandran]

Since Don has left, Vishy is taking his bugs in bulk, pending reassignment.
thanks,
	Vishy

Comment 9

[Blake Ross]

space needs to fire oncommand, for certain widgets at least.  And that 
shouldn't be called "onCheckboxClick", since it's not.

Comment 10

[Peter "jag" Annema]

So it should be per widget, and not per instance, but also not across the board 
for all widgets. And yeah, once that changes, all these "Click" handlers need to 
be renamed since they really are Command handlers, conceptually different.

Comment 11

[Paul Chen]

nav triage bug:

Would be nice to fix, but don't think we'll get to it for beta1, marking
nsbeta1-, reassigning to pchen

Comment 12

[Terri Preston]

changing qa contact to myself, this is my area now

Comment 13

[Paul Chen]

Marking nsbeta1- bugs as future to get off the radar

Comment 14

[Stephen P. Morse]

This bug mustn't be futured, it's got a severity of major.  And pchen has left 
the company, so reassigning to jag since he had some ideas posted above.

Comment 15

[Eugene Savitsky]

I believe it works now...

Comment 16

[jag (Peter Annema)]

Indeed, WFM.