Closed Bug 571104 Opened 14 years ago Closed 14 years ago

report opaque gtk theme widgets for known cases

Categories

(Core :: Widget: Gtk, defect)

x86
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b1

People

(Reporter: karlt, Assigned: karlt)

References

Details

Attachments

(1 file)

This will be useful for retained layers because drawing gtk widgets onto transparent layers is expensive.
Depends on: 555133
Attached patch patchSplinter Review
The main gain comes from GetWidgetTransparency and bug 555133 so that layers can be opaque and the NativeRenderer can use its fast path.
DRAW_IS_OPAQUE will mean the NativeRenderer fallback path will be much more efficient (for this subset of widgets) if it is used.  That probably happens much less often, but the improvement pretty much comes for free.

No rush to review this until bug 555133 is fixed.
Attachment #450223 - Flags: review?(roc)
Blocks: 564991
http://hg.mozilla.org/mozilla-central/rev/cd7f4b7db7e0
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a6
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: