571239 - Can't open attachments of certain saved messages

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[[e-mail]]

The check used to detect opening the attachment of a saved message uses the syntax of a find ".eml?" ignoring case. Unfortunately the string being searched is a Unicode string and its version of find doesn't actually have an ignore case parameter. Instead the PR_TRUE is being interpreted as an offset of 1. Fortunately the code still works in the common case of the saved message ending in .eml in lower case, as the .eml never appears at an offset of 0 anyway.

The bug occurs in attachment 381294 [details] [diff] [review], and is fixed by attachment 450349 [details] [diff] [review].

Comment 1

[Mark Banner (:standard8)]

Attachment: Attachment 450349 re-attached [r=Neil,sr=bienvenu]

Comment 2

[Mark Banner (:standard8)]

Comment on attachment 453497 [details] [diff] [review]
Attachment 450349 [details] [diff] re-attached [r=Neil,sr=bienvenu]

Didn't make 3.0.6, will re-consider for 3.0.7.

Comment 3

[Mark Banner (:standard8)]

Checked into comm-1.9.2 and the 3.1.1 relbranch for build 2:

http://hg.mozilla.org/releases/comm-1.9.2/rev/edcc1cfb7db0
http://hg.mozilla.org/releases/comm-1.9.2/rev/775c727d306d

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 453497 [details] [diff] [review]
Attachment 450349 [details] [diff] re-attached [r=Neil,sr=bienvenu]

I couldn't get this to apply on the 1.9.1 branch.