Closed Bug 571315 Opened 14 years ago Closed 9 years ago

Add a hook to mozilla-central & releases/mozilla-* to catch accidental landings on relbranches

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

Product:
Developer Services
Component:
Mercurial: hg.mozilla.org
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ehsan.akhgari, Unassigned)

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/973] ) 

The hook could check if the changesets landed are on any named branch, and if so, fail if the commit message does not include "[relbranch]" or something.
Please coord with RelEng before turning this live. 

We need to make sure our release automation handles this before this hook goes live, or else we could get unhappy surprise during a respin.
We probably want this on mozilla-central too; it occasionally has relbranches.
Summary: Add a hook to releases/mozilla-* to catch accidental landings on relbranches → Add a hook to mozilla-central & releases/mozilla-* to catch accidental landings on relbranches
I think this should be the responsibility of the release manager to track, though this certainly would help. I have a tool that watches this for me, but others might not.
You could just roll this into the tree closure hook, which is already on m-c and relbranches, and already looks for magic words.
(In reply to comment #3)
> I think this should be the responsibility of the release manager to track,
> though this certainly would help. I have a tool that watches this for me, but
> others might not.

Is that tool available somewhere for other release managers to use?
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/81]
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/81] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/966] [kanban:engops:https://kanbanize.com/ctrl_board/6/81]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/966] [kanban:engops:https://kanbanize.com/ctrl_board/6/81] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/971] [kanban:engops:https://kanbanize.com/ctrl_board/6/81]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/971] [kanban:engops:https://kanbanize.com/ctrl_board/6/81] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/973] [kanban:engops:https://kanbanize.com/ctrl_board/6/81]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/973] [kanban:engops:https://kanbanize.com/ctrl_board/6/81] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/973]
Is this still wanted?
Flags: needinfo?(rail)
I'd say no. The bug is quite old and not that active. Also adding another hook adds extra complexity and code to maintain.
Flags: needinfo?(rail)
I'm happy to close this bug then!
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.