571349 - [mozmill] testDownloadManagerClosed.js doesn't correctly cleanup downloaded files

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like that the file we download during the PB mode is active doesn't get cleaned-up correctly, because we simply look into the database to collect those files to download. But during pb mode we have a temporary table. I will have to fix that.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Files which lingering around in my download folder are:

etd_lesson2.pdf
rar_expander_v084
bzip2-1.0.5.tar.gz

So those are all files we download. Even the file when we are normally in Private Browsing mode! Ehsan, we really have to delete those temporarily files which have been downloaded in PB mode once we leave it, so I wonder why that doesn't happen in our test.

Comment 2

[Jeff Hammel]

If you can set the browser.download.dir preference to some temporary directory that would probably be sufficient (not sure if this is easy/possible at this point)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Allow user defined download list

We should simply allow the user to pass in a custom list of downloads. That way we can also make sure that the file downloaded in Private Browsing mode gets deleted.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #2)
> If you can set the browser.download.dir preference to some temporary directory
> that would probably be sufficient (not sure if this is easy/possible at this
> point)

Kinda hard to get the temporary folder from within Javascript. Now that we correctly delete our downloaded files, it should be ok. If you still think we should use a temporary folder please create a new bug.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Landed on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/c1821e538c5d
http://hg.mozilla.org/qa/mozmill-tests/rev/2633e5912e4a
http://hg.mozilla.org/qa/mozmill-tests/rev/9fdc5f2074df

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.