[DW] Drop down menus and list box border styles change after turning on DW

ASSIGNED
Assigned to

Status

()

defect
ASSIGNED
9 years ago
8 years ago

People

(Reporter: mozbugz, Assigned: bas.schouten)

Tracking

(Blocks 1 bug)

Trunk
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(7 attachments)

Reporter

Description

9 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100610 Minefield/3.7a6pre ( .NET CLR 3.5.30729) Firefox/3.6.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.3a6pre) Gecko/20100610 Minefield/3.7a6pre ( .NET CLR 3.5.30729) Firefox/3.6.3

I noticed this with a few menus.
1. remember history drop down
2. tools menu
3. help menu

Reproducible: Always

Steps to Reproduce:
1. Create a new profile using Profile Manager (firefox.exe -P)
2. Observe menu borders for the 3 menus above
3. Turn on DW/D2D in about:config
4. Restart browser using Profile Manager
5. Open the new profile
6. Review borders are changed

Actual Results:  
Border styles for Remember History, the Tools Menu, Help menu are different from the rest of the browser.

Expected Results:  
Borders should be the same as before, and should not change style at all turning on D2D/DW or turning it off

7. Turn off DW/D2D in about:config
8. Restart browser
8. See the border styles are permanently changed
Reporter

Comment 2

9 years ago
Reporter

Comment 3

9 years ago
Reporter

Updated

9 years ago
Blocks: d2d
Component: General → Theme
Version: unspecified → Trunk
Component: Theme → Graphics
Product: Firefox → Core
QA Contact: general → thebes
Reporter

Updated

9 years ago
Summary: [D2D] Drop down menus border styles change permanently after turning on DW/D2D → [D2D] Drop down menus and list box border styles change permanently after turning on DW/D2D
Assignee

Comment 5

9 years ago
Confirmed, although I have absolutely no idea what the cause is at this point.
Assignee: nobody → bas.schouten
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Reporter

Comment 6

9 years ago
I thought maybe one of the Neil's or someone familiar with layout/listboxes or XUL might make sense of it.

I even killed my profiles a few times to make sure.  I completely removed firefox, and minefield directories, and my user profile directories and at first I thought it was some kind of theme or code issue overwriting the default files.  

Nvidia 7050 / 610i driver change didn't make a difference either.

I only saw a similar issue once when services didn't work with private browsing and Win7 jumplists pref changes not doing anything between restarts.  Maybe something is not being initialized on startup here either?
Reporter

Comment 8

9 years ago
Assignee

Comment 9

9 years ago
This happens with DirectWrite only for me. What is happening (for reasons which I don't understand), is the widget is of slightly different size with DWrite on. However the visible region of the ThebesLayer is still at the original size, and because of that the background theme is drawn incorrectly.

For example for the 'Tools' menu it's normally 255 pixels wide, with DWrite on it's 256 pixels wide. However the visible region of the root thebes layer everything is drawn to is still 255 pixels wide for some reason.
Summary: [D2D] Drop down menus and list box border styles change permanently after turning on DW/D2D → [DW] Drop down menus and list box border styles change permanently after turning on DW
Reporter

Comment 10

9 years ago
(In reply to comment #9)
> This happens with DirectWrite only for me. 

Confirming the same here.  I did notice something also odd here on the View->Zoom sub menu its extra wide too if you view, then close it, and move mouse up to say something else in the view menu and go back to zoom, the sub menu is then corrected, but it only seems to be reproduceable once between browser restarts.
Reporter

Updated

9 years ago
Summary: [DW] Drop down menus and list box border styles change permanently after turning on DW → [DW] Drop down menus and list box border styles change after turning on DW
(In reply to comment #9)
> This happens with DirectWrite only for me. What is happening (for reasons which
> I don't understand), is the widget is of slightly different size with DWrite
> on. However the visible region of the ThebesLayer is still at the original
> size, and because of that the background theme is drawn incorrectly.

The sub-menus in the appmenu I think might be affected by this.

I'm (and some other people) are getting a weird extra line to the right of some
of the submenus, between the menu and the menu's shadow. For me, at least, it
only happens when DW is enabled, and D2D is disabled.

Maybe important: The menus that are affected by this do not show any keyboard
shortcuts for the commands in that menu. (History has no line, Developer has
the line, Customize has the line, Customize-Sidebars has no line)

If I enable DW, and set gfx.font_rendering.harfbuzz.level to 1, the lines
disappear, just like if I either turn on D2D or turn off DW. I'm not really
sure what harfbuzz is, though, so I don't know why it'd be different.
Assignee

Updated

9 years ago
Blocks: 569166
Posted image App menu lines
This is what the appmenu lines were looking like with just DW enabled.
This bug appears similar to Bug 474197.  The effect of extra black right popup menu border is not D2D/DW specific, for me.  The truncated right popup menu border may be D2D/DW specific or it might just cause the real problem to appear more easily in another fashion.
Reporter

Updated

9 years ago
Blocks: dwrite
Reporter

Comment 14

9 years ago
There appears to be some interesting data point differences between some of the menus and drop downs when using [DW] only with Nvidia 10-16-2010 drivers on my Nvidia 7050 with Aero Glass in Windows 7.

In Beta7 release, almost everything looks fine except for the zoom, page style and character encoding sub menus from the menu bar which have the double line look.  It also shows borders when viewing all the option pane dropdowns so no the border issue was fixed then including the options default font dropdown.

In nightly 12-02, I see page style menu is fixed, the default fonts dropdown doesn't have a border again, and zoom and character encoding submenus from the menu bar still have the double line and borders are showing on the rest of the options pane dropdowns.

Makes me wonder if there is slight code differences per menu popups and widgets, causing issues here.  

If I have time, I will try to find where some of the changes occurred, since I  forgot to check on this.
Reporter

Comment 15

9 years ago
Ok, Another oddity, turning on D3D9 will make them double line border appear bolder black borders no matter if DW is on and/or or D2D on.  I have a feeling that Stanimir is onto something over in bug 474197 like pixel alignment is weird.  And the thing about submenus like from the old App menu iteration and toolbars submenu is they were both re-coded and both no long show problems in the same places, where as the rest probably haven't been touched.

Comment 16

9 years ago
Comment 4 implies that this also occurs to html <select> popups, which are an entirely different implementation from menus. 

I'm guessing that the size of the frames is correct but the widget is one pixel too large?
Using the now officially released Firefox 4 I don't seem to observe the described problem.
Reporter

Comment 18

8 years ago
Stan, did you try just with D3D9 enabled and DW enabled, not the direct write font pref, but turn that off, and force on Direct write?  

Here is what I been testing with to see this bug:

gfx.font_rendering.directwrite.use_gdi_table_loading;false
gfx.font_rendering.directwrite.enabled;true
gfx.direct2d.force-enabled;false
gfx.direct2d.disabled;false
layers.prefer-d3d9;true

I think this disappeared as well, Its gone from my setup using the latest nightly and FF4 release - I'm testing my Nvidia 7050 with drivers from october 2010.

attachment 450601 [details] still shows up under these conditions DW on/D3D9 with older Nvidia hardware, as Neil mentioned in comment 16, maybe a different bug.

attachment 450616 [details] appears to have been there in 12/29 build, but no more either.
> gfx.font_rendering.directwrite.use_gdi_table_loading;false
> gfx.font_rendering.directwrite.enabled;true
> gfx.direct2d.force-enabled;false
> gfx.direct2d.disabled;false

These appears to be the defaults, now.

> layers.prefer-d3d9;true

This one I've set like that, now.

> I think this disappeared as well, Its gone from my setup using the latest 
> nightly and FF4 release - I'm testing my Nvidia 7050 with drivers from october 
> 2010.
> 
> attachment 450601 [details] still shows up under these conditions DW on/D3D9 with older 
> Nvidia hardware, as Neil mentioned in comment 16, maybe a different bug.

I have NVIDIA GeForce GTS 250 video card, driver version 8.17.12.5896 (7th of September 2010) - I don't seems to observe the problem using the above configuration.  Can't say about older Nvidia hardware.
You need to log in before you can comment on or make changes to this bug.