[mozmill] Can't validate identity-icon-label with value "VeriSign, Inc. (US)" (testGreenLarry.js and testSecurityNotification.js)

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
With Firefox 4 the country is displayed in its own label element. That's why we get the following failure when validating:

Could not validate element ID: identity-icon-label with value VeriSign, Inc. (US)'
(Assignee)

Comment 1

8 years ago
Created attachment 450627 [details] [diff] [review]
Patch v1
Attachment #450627 - Flags: review?(anthony.s.hughes)
(Assignee)

Updated

8 years ago
Summary: [mozmill] Can't validate identity-icon-label with value "VeriSign, Inc. (US)" (testGreenLarry) → [mozmill] Can't validate identity-icon-label with value "VeriSign, Inc. (US)" (testGreenLarry.js and testSecurityNotification.js)
(Assignee)

Comment 2

8 years ago
Created attachment 450629 [details] [diff] [review]
Patch v1.1 [checked-in]

testSecurityNotification is also affected. The test in that file is the same as the one we have in testGreenLarry. I removed it in favor of the latter test. Further I have changed the website to AMO which is a bit faster and will make lesser problems with updates.

Once we create a shared API for the security related functions we should also have a better method to extract information from the security certificate, i.e. city, state, and country. For now the changes will work.
Attachment #450627 - Attachment is obsolete: true
Attachment #450629 - Flags: review?(anthony.s.hughes)
Attachment #450627 - Flags: review?(anthony.s.hughes)
Attachment #450629 - Flags: review?(anthony.s.hughes) → review+
(Assignee)

Comment 3

8 years ago
Landed on default as:
http://hg.mozilla.org/qa/mozmill-tests/rev/b75137ff3919

I will come up with a patch for branch too.
(Assignee)

Comment 4

8 years ago
Created attachment 450684 [details] [diff] [review]
Patch v1 (mozilla1.9.2/1) [checked-in]
Attachment #450684 - Flags: review?(anthony.s.hughes)
(Assignee)

Updated

8 years ago
Attachment #450629 - Attachment description: Patch v1.1 → Patch v1.1 [checked-in]
Attachment #450684 - Flags: review?(anthony.s.hughes) → review+
(Assignee)

Comment 5

8 years ago
Landed on branches too:
http://hg.mozilla.org/qa/mozmill-tests/rev/04d466bf14fd
http://hg.mozilla.org/qa/mozmill-tests/rev/2d48e62c1e54
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 6

8 years ago
The favicon check is still broken. I will work on a follow-up patch which will fix this specific item.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

8 years ago
Attachment #450684 - Attachment description: Patch v1 (mozilla1.9.2/1) → Patch v1 (mozilla1.9.2/1) [checked-in]
(Assignee)

Comment 7

8 years ago
http://brasstacks.mozilla.com/couchdb/mozmill/_design/reports/_show/report/9fd5d15275b511df9f76005056a533eb

Controller.assertProperty(ID: page-proxy-favicon) : https://addons.mozilla.org/media//img/favicon.ico == https://addons.mozilla.org/favicon.ico

We should simply check for the host instead of the full url. Could be similar to the issue we had with the favicon for Bugzilla.
Status: REOPENED → ASSIGNED
(Assignee)

Comment 8

8 years ago
Created attachment 450891 [details] [diff] [review]
Fix favicon url
Attachment #450891 - Flags: review?(anthony.s.hughes)
Attachment #450891 - Flags: review?(anthony.s.hughes) → review+
(Assignee)

Comment 9

8 years ago
Landed follow-up on all branches:
http://hg.mozilla.org/qa/mozmill-tests/rev/dd74cbf7b0c3
http://hg.mozilla.org/qa/mozmill-tests/rev/1392424a9d25
http://hg.mozilla.org/qa/mozmill-tests/rev/8a7c71b29bb1
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago8 years ago
Resolution: --- → FIXED
(Assignee)

Comment 10

7 years ago
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Security → Mozmill Tests
Product: Firefox → Mozilla QA
QA Contact: firefox → mozmill-tests
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.